[Patches] [ python-Patches-555085 ] timeout socket implementation

[noreply@sourceforge.net]

Patches item #555085, was opened at 2002-05-12 08:11
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=555085&group_id=5470

Category: Library (Lib)
Group: Python 2.3
Status: Open
Resolution: None
Priority: 5
Submitted By: Michael Gilfix (mgilfix)
Assigned to: Guido van Rossum (gvanrossum)
Summary: timeout socket implementation

Initial Comment:
This implements bug #457114 and implements timed socket
operations. If a timeout is set and the timeout period
elaspes before the socket operation has finished, a
socket.error exception is thrown.

This patch integrates the functionality at two levels:
the timeout capability is integrated at the C level in
socketmodule.c. Socket.py was also modified to update 
fileobject creation on a win platform to handle the
case of the underlying socket throwing an exception.
The tex documentation was also updated and a new
regression unit was provided as test_timeout.py.

----------------------------------------------------------------------

>Comment By: Michael Gilfix (mgilfix)
Date: 2002-06-05 18:23

Message:
Logged In: YES 
user_id=116038

I've addressed all the issues brought up by Guido. The 2nd
version of the patch is attached here. In this version, I've
modified test_socket.py to include tests for the _fileobject
class in socket.py that was modified by this patch.
_fileobject needed to be modified so that data would not be
lost when the underlying socket threw an expection (data was
no longer accumulated in local variables). The tests for the
_fileobject class succeed on older versions of python
(tested 2.1.3) and pass on the newer version of python.

----------------------------------------------------------------------

Comment By: Guido van Rossum (gvanrossum)
Date: 2002-05-23 16:18

Message:
Logged In: YES 
user_id=6380

For a detailed review, see

http://mail.python.org/pipermail/python-dev/2002-May/024340.html

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=555085&group_id=5470