[Patches] [ python-Patches-533070 ] Silence AIX C Compiler Warnings.

[noreply@sourceforge.net]

Patches item #533070, was opened at 2002-03-21 08:25
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=533070&group_id=5470

Category: Build
Group: Python 2.2.x
>Status: Closed
>Resolution: Fixed
Priority: 3
Submitted By: Ralph Corderoy (ralph)
>Assigned to: Neal Norwitz (nnorwitz)
Summary: Silence AIX C Compiler Warnings.

Initial Comment:
AIX 3.2.5 C compiler gives warnings during compile of 
Objects/object.c and Modules/signalmodule.c due to
superfluous use of the ampersand address operator in 
front of a function name.  Since the code elsewhere 
consistently uses plain `foo' to represent a pointer to
the function foo and not `&foo' it seems best to make
the code consistent and silence these warnings at the
same time.


----------------------------------------------------------------------

>Comment By: Neal Norwitz (nnorwitz)
Date: 2002-06-13 17:43

Message:
Logged In: YES 
user_id=33168

Checked in as:  object.c 2.162.6.4 and 2.179
signalmodule.c 2.60.10.2 and 2.69

----------------------------------------------------------------------

Comment By: Neal Norwitz (nnorwitz)
Date: 2002-03-21 13:25

Message:
Logged In: YES 
user_id=33168

I'm sorry, you misunderstood.  I agree that the patch should
be applied.  I was reporting that there were no problems
created on other platforms.  -- Neal

----------------------------------------------------------------------

Comment By: Ralph Corderoy (ralph)
Date: 2002-03-21 13:17

Message:
Logged In: YES 
user_id=911

Dear nnorwitz, I'm aware that gcc doesn't issue the warning.
However, AIX 3.2.5's C compiler does.  And the source
consistently omits the ampersand elsewhere.  So there seems
little reason not to make the change and increase the
number of `clean' builds out there.  Cheers, Ralph.

----------------------------------------------------------------------

Comment By: Neal Norwitz (nnorwitz)
Date: 2002-03-21 12:17

Message:
Logged In: YES 
user_id=33168

Builds for me without warnings on Linux gcc 2.96 & 
solaris 8, gcc 2.95.3.

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=533070&group_id=5470