[Patches] [ python-Patches-499062 ] Minor typo in test_generators.py

[noreply@sourceforge.net]

Patches item #499062, was opened at 2002-01-03 13:32
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=499062&group_id=5470

Category: Tests
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 3
Submitted By: Uche Ogbuji (uche)
Assigned to: Tim Peters (tim_one)
Summary: Minor typo in test_generators.py

Initial Comment:
This one caused me a bit of confusion.  Traditionally
"leaves" refer to tree nodes with no children.

----------------------------------------------------------------------

>Comment By: Tim Peters (tim_one)
Date: 2002-03-10 03:00

Message:
Logged In: YES 
user_id=31435

Changed, in
dist/src/Lib/test/test_generators.py; new revision: 1.31
nondist/peps/pep-0255.txt; new revision: 1.18

----------------------------------------------------------------------

Comment By: Uche Ogbuji (uche)
Date: 2002-01-03 23:06

Message:
Logged In: YES 
user_id=38966

No more argument.  s/leaves/labels it is.  Thanks.

----------------------------------------------------------------------

Comment By: Tim Peters (tim_one)
Date: 2002-01-03 19:35

Message:
Logged In: YES 
user_id=31435

Yes, I think "leaf" == "no kids" is universally accepted.

I don't like changing it to plain "nodes", though, because 
the example code does not generate the nodes, it generates 
only the node labels -- someone confused by the misuse 
of "leaves" here is also likely to be confused by the 
misuse of "nodes" -- and I'm going to reduce the priority 
of this patch every time you argue back <wink>.

----------------------------------------------------------------------

Comment By: Uche Ogbuji (uche)
Date: 2002-01-03 19:23

Message:
Logged In: YES 
user_id=38966

It's s/leaves/nodes/.  Maybe I've been working with DOM too
much.  At any rate, I have always thought of leaf nodes as
only those with no children.

It doesn't look as if anything from my patch made it
through: neither the comment nor the patch.  Sometimes I
hate SF.

I'll try again, though it hardly seems necessary...


----------------------------------------------------------------------

Comment By: Tim Peters (tim_one)
Date: 2002-01-03 19:18

Message:
Logged In: YES 
user_id=31435

Assigned to me; added a "Tests" category and recategorized 
accordingly.

Uche, if you tried to upload a patch, it didn't work (did 
you remember to check the upload box)?  What is that you 
want to see changed?  s/leaves/labels/?  Note that the 
example in the docstring test is lifted directly out of PEP 
255, so tell me what would shut you up <wink> and I'll make 
the change in both places.

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=499062&group_id=5470