[Patches] [ python-Patches-529408 ] fix random.gammavariate bug #527139

[noreply@sourceforge.net]

Patches item #529408, was opened at 2002-03-13 07:15
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=529408&group_id=5470

Category: Library (Lib)
Group: Python 2.3
Status: Open
Resolution: None
Priority: 5
Submitted By: John Machin (sjmachin)
>Assigned to: Tim Peters (tim_one)
Summary: fix random.gammavariate bug #527139

Initial Comment:
random.gammavariate() doesn't work for gamma < 0.5

See detailed comment on bug # 527139

----------------------------------------------------------------------

>Comment By: Tim Peters (tim_one)
Date: 2002-03-18 00:32

Message:
Logged In: YES 
user_id=31435

John, if I were you <wink> I'd leave stdgamma alone, except 
for adding this code to its start:

import warnings
warnings.warn("The stdgamma function is deprecated; "
              "use gammavariate() instead",
              DeprecationWarning)

Then we can remove stdgamma in 2.4.  2.2.1 will probably go 
out on Monday night, so it would be nice to get this done 
before then.  OTOH, I expect there will be a 2.2.2 later, 
so not a tragedy if it's not.

----------------------------------------------------------------------

Comment By: John Machin (sjmachin)
Date: 2002-03-17 15:46

Message:
Logged In: YES 
user_id=480138

OK; I understand the problems with the patch. Not sure 
about the way forward -- shall I prepare a patch that just 
fixes gammavariate() and leaves stdgamma() there (with 
warning in the comments: deprecated? will be removed in 
2.x?)? Do you want it real soon now (for 2.2.1)?



----------------------------------------------------------------------

Comment By: Tim Peters (tim_one)
Date: 2002-03-17 14:42

Message:
Logged In: YES 
user_id=31435

Michael, this definitely doesn't belong in 2.2.1 as-is, 
because it removes a currently-exported name (buggy or not, 
sensible or not, somebody may be using random.stdgamma now 
and be happy with it).

John, if you're going to remove stdgamma, you need also to 
remove its (string) name from the module's __all__ list 
(right before the _verify() function).

----------------------------------------------------------------------

Comment By: Tim Peters (tim_one)
Date: 2002-03-16 12:38

Message:
Logged In: YES 
user_id=31435

Possibly, depending on whether it belongs in 2.3 -- I'm 
spread too thin to review it now.

----------------------------------------------------------------------

Comment By: Michael Hudson (mwh)
Date: 2002-03-16 11:53

Message:
Logged In: YES 
user_id=6656

Tim, do you think this should go into 2.2.1?

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=529408&group_id=5470