[Patches] [ python-Patches-554718 ] OpenBSD updates for build process

noreply@sourceforge.net noreply@sourceforge.net
Tue, 21 May 2002 02:25:40 -0700


Patches item #554718, was opened at 2002-05-11 02:20
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=554718&group_id=5470

Category: Build
Group: Python 2.1.2
Status: Open
Resolution: None
Priority: 5
Submitted By: Matt Behrens (mattbehrens)
Assigned to: Nobody/Anonymous (nobody)
Summary: OpenBSD updates for build process

Initial Comment:
The following patches are currently in our packaging 
system.  A brief summary:

- Use 'cc -shared' to build shared libraries, as is 
strictly correct on OpenBSD.

- Use -fPIC instead of -fpic.

- Use OpenBSD threads.

- Fix the test_fcntl test.

Another patch item will be posted shortly for Python 
2.2, for similar items.

----------------------------------------------------------------------

>Comment By: Martin v. Löwis (loewis)
Date: 2002-05-21 11:25

Message:
Logged In: YES 
user_id=21627

What architectures have been using ELF before OpenBSD 2.8?
I'd still like to simplify this logic, perhaps by removing
support for systems that nobody uses anymore.

As for -pthread: the test for OpenBSD specifically should
go. Instead, I propose to integrate this with the -Kpthread
logic: there should be a sequence of options tested, and the
first one shown to enable pthreads should be used. The set
of options should be -Kpthread (for SysV), -pthread (for BSD
and Linux), -pthreads (for gcc on Solaris).

I'd be willing to accept a test-for-system for 2.1, since it
does not have the -Kpthread test, but for 2.2 and 2.3, we
should remove the set of tests used.

Also, why does it AC_DEFINE _REENTRANT and _POSIX_THREADS?
Those two should be implied by -pthread.

Also, what OpenBSD releases could be deprecated without
losing users?

----------------------------------------------------------------------

Comment By: Matt Behrens (mattbehrens)
Date: 2002-05-21 00:47

Message:
Logged In: YES 
user_id=240525

>From brad@:

> There isn't a test for -pthread option so Python will not
correctly
> compile with threads support. Testing for libc_r is NOT
correct.

So, the answer is no, the standard POSIX threads test does
not work.


----------------------------------------------------------------------

Comment By: Matt Behrens (mattbehrens)
Date: 2002-05-20 14:17

Message:
Logged In: YES 
user_id=240525

Okay, well let's comment in this bug then.  Changing the
subject and closing out 554719.  I'll put all patches on
this bug.

I am trying to verify most of this with brad@openbsd.org,
who has contributed some parts of these patches.

On cc -shared, this is my understanding:

-  All OpenBSD ELF architectures have always used cc -shared.

-  Before OpenBSD 2.8, a.out architectures used ld -Bshareable.

-  As of OpenBSD 2.8, cc -shared worked on a.out
architectures as well, and ld -Bshareable became deprecated.
On -fPIC: -fPIC has always worked.  The difference between
-fpic and -fPIC is simply that -fpic is less efficient.

On threads, I am still waiting for an answer from brad@,
this is his change.  I'll ask him again today.

Thanks.


----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2002-05-12 18:49

Message:
Logged In: YES 
user_id=21627

The -shared chunk looks frightening. What is the first BSD
release where ld -Bshareable stops working? Could you
rearrange this to integrate the version numbers into the
OpenBSD* match? Also, what releases need the ELF test? Could
that be restricted to the older releases, too?

Would it be acceptable to stop supporting OpenBSD 0 and 1?

Is usage of -fPIC correct on OpenBSD 0.x? If not, what is
the first release that supports -fPIC?

It looks like that 'OpenBSD threads' are 'POSIX threads'?
Why does the existing test for Posix threads fail to detect
their presence?

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=554718&group_id=5470