[Patches] [ python-Patches-472523 ] Reminder: 2.3 should check tp_compare

[noreply@sourceforge.net]

Patches item #472523, was opened at 2001-10-18 15:17
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=472523&group_id=5470

Category: None
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 6
Submitted By: Guido van Rossum (gvanrossum)
Assigned to: Guido van Rossum (gvanrossum)
Summary: Reminder: 2.3 should check tp_compare

Initial Comment:
In 2.3, the outcome of tp_compare should be required to
be -1, 0 or 1; other values should be considered
*illegal*.

(In 2.2, the docs were changed to stress this but for
backwards compatibility this isn't enforced.)

----------------------------------------------------------------------

>Comment By: Guido van Rossum (gvanrossum)
Date: 2002-05-31 16:06

Message:
Logged In: YES 
user_id=6380

I have checked in something quite different that implements
the idea here.

It does check that for an error, -2 or -1 is returned; this
can be tightened to require -2 in the future.

----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2002-05-08 03:46

Message:
Logged In: YES 
user_id=21627

I think warning the user is the best thing we can offer;
making it an error would break extensions - users can
disable the warning if they want to. Hopefully, they will
report the problem to the extension author, and hopefully,
the extension author tests his code with the new Python
release, to notice the problem before his users do.

Instances are exempted from the warnings because they
already use the "target result set": -1,0,1 for regular
outcome; -2 for exceptions. The original rationale for this
tightening of the result set is to let -2 indicate
exceptions in future Python releases. Perhaps it should also
check that, if an exception occured, that the result value
is -2.

----------------------------------------------------------------------

Comment By: Raymond Hettinger (rhettinger)
Date: 2002-05-08 03:20

Message:
Logged In: YES 
user_id=80475

Here are a few thoughts from my review:

Patch needs to diff from current version, 2.173 of object.c

Patch compiles okay.  Code passes regrtest.py without 
generating warnings.  Code agrees with docs.  Scanned 
remaining code base and found no other direct calls to 
tp_compare in other *.c or *.h files.

If this were an error rather than a warning, convention 
would indicate a BadInternalCall since this can only be 
generated by an extension writer.  I'm wondering if we are 
warning the wrong person.  An old extension recompiled for 
Py2.3 will compile fine but then warn an end-user (not the 
extension writer) about a mysterious tp_compare that they 
can neither see, nor touch.

In try_3way_compare, the warning is not given for 
instances.  Are we exempting instances from the warnings?

In try_3way_compare, the warning is given in the 
section, "v's comparison" but is omitted in "w's 
comparison" which follows.

I think the priority should be raised on this patch because 
it needs to be in-place for Py2.3a so that we get the 
earliest possible notice if the warning clashes with use in 
one of the popular extensions.

----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2002-03-09 06:54

Message:
Logged In: YES 
user_id=21627

Attached is a patch that implements this test, producing a
warning if tp_compare does not follow that restriction.

----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2002-03-09 06:54

Message:
Logged In: YES 
user_id=21627

Attached is a patch that implements this test, producing a
warning if tp_compare does not follow that restriction.

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=472523&group_id=5470