[Patches] [ python-Patches-550765 ] SocketServer behavior

noreply@sourceforge.net noreply@sourceforge.net
Sat, 02 Nov 2002 09:28:53 -0800


Patches item #550765, was opened at 2002-04-30 22:06
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=550765&group_id=5470

Category: Library (Lib)
Group: Python 2.3
Status: Open
Resolution: None
Priority: 5
Submitted By: Michael Gilfix (mgilfix)
>Assigned to: Martin v. L÷wis (loewis)
Summary: SocketServer behavior

Initial Comment:
A bug, or lack of behavior in ServerSocket.py was
exposed while created a unit test for Python 2.3. As of
2.3, signals between threads propagate differently.
When cancelling a server that implemented threading
with a keyboard interrupt, the server would shut down
but not terminate (waiting on client threads).

The fit for this was to make the client threads
daemon-threads with the setDaemon call. Because this
was non-apparent, this patch adds a member variable
which acts as a hook and makes it clear that clients
need to either set or unset the variable when deriving
the class to control this behavior.

setDaemon is off by default, as this is thought to be
the consensus behavior.

----------------------------------------------------------------------

Comment By: Martin v. L÷wis (loewis)
Date: 2002-06-04 10:31

Message:
Logged In: YES 
user_id=21627

I recommend to approve this patch.

----------------------------------------------------------------------

Comment By: Michael Gilfix (mgilfix)
Date: 2002-06-03 18:45

Message:
Logged In: YES 
user_id=116038

All Address in the new patch. See SocketServer.py.patch.2.

----------------------------------------------------------------------

Comment By: Martin v. L÷wis (loewis)
Date: 2002-06-02 19:44

Message:
Logged In: YES 
user_id=21627

Could you please provide changes to the documentation as
well (i.e. Doc/lib/libsocksvr.tex, and Misc/NEWS)?

There is a typo: 'chanegs' -> 'changes'

There is no need to attach the modified source to the patch;
the context diff is enough.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=550765&group_id=5470