[Patches] [ python-Patches-633425 ] bz2 compression module

noreply@sourceforge.net noreply@sourceforge.net
Tue, 05 Nov 2002 09:09:56 -0800


Patches item #633425, was opened at 2002-11-04 19:07
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=633425&group_id=5470

Category: Modules
Group: Python 2.3
>Status: Closed
Resolution: Accepted
Priority: 3
Submitted By: Gustavo Niemeyer (niemeyer)
Assigned to: Gustavo Niemeyer (niemeyer)
Summary: bz2 compression module

Initial Comment:
As discussed in python-dev, here is the patch
implementing the bz2 module, including comrehensive
documentation and tests.


----------------------------------------------------------------------

>Comment By: Gustavo Niemeyer (niemeyer)
Date: 2002-11-05 17:09

Message:
Logged In: YES 
user_id=7887

Applied as:

setup.py:1.112->1.113 
Doc/Makefile.deps:1.89->1.90 
Doc/lib/lib.tex:1.204->1.205 
Doc/lib/libbz2.tex:INITIAL->1.1 
Lib/test/test_bz2.py:INITIAL->1.1 
Misc/NEWS:1.508->1.509 
Modules/bz2module.c:INITIAL->1.1 

Thank you!

----------------------------------------------------------------------

Comment By: Martin v. L÷wis (loewis)
Date: 2002-11-04 23:32

Message:
Logged In: YES 
user_id=21627

The patch looks fine overall, so please apply it. Don't
forget to add an entry to Misc/NEWS. Providing an
appropriate entry in Modules/Setup.dist might also be a good
idea.

A couple of spelling corrections:
- Use imperative for doc strings, not indicative. I.e. write
"Return the next line", not "Return next line".

- Review the text for missing articles. In general, an
article is needed before every noun in English. A native
speaker should review this after checkin - I don't think we
need to find all grammar errors on SF.

- "one shot decompression" -> "one-shot decompression"


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=633425&group_id=5470