[Patches] [ python-Patches-639371 ] Removal of FreeBSD 5.0 specific test

noreply@sourceforge.net noreply@sourceforge.net
Sun, 17 Nov 2002 12:49:29 -0800


Patches item #639371, was opened at 2002-11-16 17:48
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=639371&group_id=5470

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Marc Recht (marc)
Assigned to: Nobody/Anonymous (nobody)
Summary: Removal of FreeBSD 5.0 specific test

Initial Comment:
After latest Additions to the FreeBSD 5.0-current
headers, the
special case isn't needed any longer. The two last
problematic 
functions are ctermid_r and setgroups which aren't
defined in the POSIX/XOPEN case. This patch works
around the problem by
setting CFLAGS with -Wall -Werror for gcc before
checking for
this two functions.

----------------------------------------------------------------------

>Comment By: Martin v. L÷wis (loewis)
Date: 2002-11-17 21:49

Message:
Logged In: YES 
user_id=21627

Can you please explain the purpose of setting CFLAGS first
to MY_CPPFLAGS etc? Also, why are you seeting OLDFLAGS
between the if and the then?

Also, setting -Werror might have unintended site effects,
IMO, testing for a declaration is better done by checking
whether the address of a function can be taken.

Apart from that, the patch looks good.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=639371&group_id=5470