[Patches] [ python-Patches-644895 ] socketmodule.c cleanup

noreply@sourceforge.net noreply@sourceforge.net
Wed, 27 Nov 2002 13:03:28 -0800


Patches item #644895, was opened at 2002-11-27 10:54
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=644895&group_id=5470

Category: Build
Group: Python 2.2.x
Status: Open
Resolution: None
Priority: 5
Submitted By: Tim Rice (tim1470)
Assigned to: Nobody/Anonymous (nobody)
Summary: socketmodule.c cleanup

Initial Comment:
Modules/socketmodule.c is uses socklen_t in some places
and int in
others. This patch corrects this. This is important on
any platform
where socklen_t should be something other than int.

patch against release22-maint branch pulled 29 Nov 2002



----------------------------------------------------------------------

>Comment By: Tim Rice (tim1470)
Date: 2002-11-27 13:03

Message:
Logged In: YES 
user_id=618097

UnixWare, Solaris.
I'ts only compiler warnings. It does build.
Ignore it if you want. I'll try and find some time for 2.3

----------------------------------------------------------------------

Comment By: Martin v. L÷wis (loewis)
Date: 2002-11-27 12:55

Message:
Logged In: YES 
user_id=21627

What platforms specifically have this problem, i.e. on what
system does the socket module actually behave incorrectly?

For Python 2.2.x, no patches will be accepted that are
merely beautifications, without actually fixing any real bug
on real systems.

So I suggest that you port your patch to CVS Python 2.3.

----------------------------------------------------------------------

Comment By: Tim Rice (tim1470)
Date: 2002-11-27 12:10

Message:
Logged In: YES 
user_id=618097

Rats,  the checkbox got me again.

----------------------------------------------------------------------

Comment By: Martin v. L÷wis (loewis)
Date: 2002-11-27 11:54

Message:
Logged In: YES 
user_id=21627

There's no uploaded file!  You have to check the
checkbox labeled "Check to Upload & Attach File"
when you upload a file.

Please try again.

(This is a SourceForge annoyance that we can do
nothing about. :-( )

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=644895&group_id=5470