[Patches] [ python-Patches-614055 ] OpenVMS patches

[noreply@sourceforge.net]

Patches item #614055, was opened at 2002-09-24 23:34
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=614055&group_id=5470

Category: Core (C code)
Group: Python 2.3
Status: Open
Resolution: None
Priority: 5
Submitted By: Piéronne Jean-François (pieronne)
Assigned to: Nobody/Anonymous (nobody)
Summary: OpenVMS patches

Initial Comment:
The attach file contains the patches of the Core files necessary to build Python for OpenVMS.
All the patches used conditional compilation test on __VMS, so I may not  be disruptive for the initial 
code.

11 files have been updated:

Python/exceptions.c
Python/import.c
Modules/getbuildinfo.c
Modules/getpatch.c
Modules/main.c
Modules/posixmodule.c
Modules/pwdmodule.c
Modules/socketmodule.c
Modules/stringobject.c
Modules/_hotshot.c
include/pyerrors.h


Jean-François

----------------------------------------------------------------------

>Comment By: Piéronne Jean-François (pieronne)
Date: 2002-10-03 13:57

Message:
Logged In: YES 
user_id=414701

After testing using 20002-10-03_070000 some patches failed, This new version apply correctly.

Jean-François

----------------------------------------------------------------------

Comment By: Piéronne Jean-François (pieronne)
Date: 2002-10-03 09:38

Message:
Logged In: YES 
user_id=414701

I have attach a new version(vms02.diff)  using the latest CVS snapshot, I have also slightly update patch of main.c


Thanks,


Jean-François

----------------------------------------------------------------------

Comment By: Piéronne Jean-François (pieronne)
Date: 2002-09-25 22:03

Message:
Logged In: YES 
user_id=414701

Comment seem to be missing.

VMSerror is used by many specifics module which I have not currently provide.
I have correct the typo  VMSerror --> VMSError

formatting problem:
Well, this is the formatting used by Uwe Zessin (and mostly generate by the editor LSE) who has done the initial 
port.
I have not check/update his code because I did'nt know it is required, I have just found the "Style Guide for C 
Code".
I have now update the code, only the VMS part ;-)

Compute of the link time:
Really necessary, sure it is not. But, IMHO, it is more useful to have the link time than the compile time of one 
source file.
What is the problem?


psxmod_gat_psxpath, psxmod_to_vms_action:
You are right.
During the cleaning process of the code of Uwe  (I have remove some part), I have missed this optimisation and to 
remove the, then,  unused routine psxmod_to_vms.
Done, thanks.

I have attach a new version: vms01.diff

Tell me if you find other problem into this version.

Thanks for your help.

----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2002-09-25 15:02

Message:
Logged In: YES 
user_id=21627

I have a number of comments and questions:

- What is the purpose of VMSerror? It appears to be unused.
Can you use just OSError instead? If not, it should be VMSError.

- There are various formatting problems (indentation, spaces
after function names).

- Is it really necessary to compute the link time?

- Why do you need psxmod_gat_psxpath? Copying into
psxmod_gt_psxpath appears to do the same thing?

- what is the purpose of psxmod_to_vms_action?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=614055&group_id=5470