[Patches] [ python-Patches-619108 ] Fix test_pep277 on Win9x

[noreply@sourceforge.net]

Patches item #619108, was opened at 2002-10-06 03:13
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=619108&group_id=5470

Category: Windows
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Mark Hammond (mhammond)
Assigned to: Martin v. Löwis (loewis)
Summary: Fix test_pep277 on Win9x

Initial Comment:
In the interests of getting test_pep277 running for Tim
<wink>, sys.getwindowsversion() should be added.  Chose
sys as that is where all other version related
information is found.  Happy to move to the os module
is desired, but posixmodule.c is enough of a mess already.

Patch even includes doc :)

Martin, could you please review?

----------------------------------------------------------------------

>Comment By: Martin v. Löwis (loewis)
Date: 2002-10-06 14:18

Message:
Logged In: YES 
user_id=21627

Mark wants it to be in sys; I have no preference in either
direction.

----------------------------------------------------------------------

Comment By: Guido van Rossum (gvanrossum)
Date: 2002-10-06 13:53

Message:
Logged In: YES 
user_id=6380

Did you mean sys, or os?

----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2002-10-06 13:41

Message:
Logged In: YES 
user_id=21627

Attached is a patch that uses getwindowsversion as I just
suggested. Back to Mark for comments and possible checkin.
The libsys.tex change also needs a \versionadded.

If sys.getwindowsversion remains signed, this patch must be
adjusted.

----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2002-10-06 09:25

Message:
Logged In: YES 
user_id=21627

I'm in favour of adding sys.getwindowsversion.

As for disabling the test, it seems like Tim prefers to add
sys.path.supports_unicode_filenames, with the following
settings:

posixpath, macpath, dospath, os2emxpath: False
ntpath: getwindowsversion() < 0x80000000

I'm somewhat confused about the signedness of GetVersion(),
though - it appears that it is unsigned in C. If so, I think
the Python wrapper should also return non-negative numbers only.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=619108&group_id=5470