[Patches] [ python-Patches-621205 ] Tkinter updates for tk8.4

noreply@sourceforge.net noreply@sourceforge.net
Sun, 13 Oct 2002 03:22:53 -0700


Patches item #621205, was opened at 2002-10-10 11:01
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=621205&group_id=5470

Category: Tkinter
Group: Python 2.2.x
>Status: Closed
>Resolution: Accepted
Priority: 5
Submitted By: Martin Franklin (mfranklin1)
Assigned to: Martin v. Löwis (loewis)
Summary: Tkinter updates for tk8.4

Initial Comment:
This patch includes three new widgets : 

PanedWindow, Spinbox and LabelFrame

I have also added the edit_* methods to the Text widget

It requires tk 8.4 but should not fall over on earlier versions 
(provided the end user does not use these options)


I've uploaded a diff -c 

----------------------------------------------------------------------

>Comment By: Martin v. Löwis (loewis)
Date: 2002-10-13 12:22

Message:
Logged In: YES 
user_id=21627

Thanks for the patch. Applied as Tkinter.py 1.165; ACKS
1.210; NEWS 1.499;

----------------------------------------------------------------------

Comment By: Martin Franklin (mfranklin1)
Date: 2002-10-10 21:32

Message:
Logged In: YES 
user_id=482545


Done.  I've uploaded the latest diff file.


----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2002-10-10 19:09

Message:
Logged In: YES 
user_id=21627

The text of the doc strings is all fine; as you know, they
ought to be in inidicative form (or is it imperative?).
However, please separate the first sentence from the
following ones by an empty line. This allows interactive
tools to print a tooltip.

----------------------------------------------------------------------

Comment By: Martin Franklin (mfranklin1)
Date: 2002-10-10 17:02

Message:
Logged In: YES 
user_id=482545


The second patch (2002-10-10 09:18) is (was) the correct 
version I will upload a new one with your comments in mind.  

The test for Tcl version was commented out to get a response 
(and it did!) so I will remove it.

The pathName comments should have been removed and will 
be soon (as will the blank lines)

I have also gone on and added a few comments to the Button 
and Label widget (these now support the -compound  option)
and I have updated the module comment at the top of the 
module to include the new Widgets so pydoc can pick them up.

The Wm class has sprung a new method

I can't find any more updates on the tcl tk site... but there may 
be some small ones....

I would be interested in your comments on the style of the doc 
strings for the new widgets.  Basically I have cut and pasted 
from the tk command reference pages (with a few light edits)  
This means they are different from the older widgets  



----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2002-10-10 16:46

Message:
Logged In: YES 
user_id=21627

Which version of the patch is the correct one?

There is no need to test the Tcl version when wrapping new
Tcl features: as long as Tkinter continues to import
correctly on older Tk versions, it is fine that invoking the
newer wrappers will cause Tcl errors.

What are the pathName comment lines?

Please don't add that many blank lines.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=621205&group_id=5470