[Patches] [ python-Patches-626485 ] Support Unicode normalization
noreply@sourceforge.net
noreply@sourceforge.net
Wed, 23 Oct 2002 03:36:43 -0700
Patches item #626485, was opened at 2002-10-21 19:02
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=626485&group_id=5470
Category: Core (C code)
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Martin v. Löwis (loewis)
Assigned to: M.-A. Lemburg (lemburg)
Summary: Support Unicode normalization
Initial Comment:
This patch adds support for the normalization forms
NFC, NFKC, NFD, NFKD. It passes the
NormalizationTest-3.2.0.txt tests.
----------------------------------------------------------------------
>Comment By: M.-A. Lemburg (lemburg)
Date: 2002-10-23 10:36
Message:
Logged In: YES
user_id=38388
One more minor nit: the indentation in the C file is 4
chars, please reindent your code accordingly
----------------------------------------------------------------------
Comment By: M.-A. Lemburg (lemburg)
Date: 2002-10-23 10:27
Message:
Logged In: YES
user_id=38388
The patch looks Ok except for a few nits:
* I'd rather like a single API normalize(form) which takes
the form as string argument instead of NFKD, etc.
* __getrecord should be renamed to _getrecord_ex;
perhaps both should use a different name altogether,
e.g. getunicoderecord
* I think you have to add some #ifdef Py_UNICODE_WIDE
in the code to avoid compiler warnings for narrow builds
about non-const if expressions being always true due to
size limits.
* The filenames you are using should not include the '-Latest'
suffix. If you download the files from unicode.org via FTP
they don't have this extension.
* The skip test message should include a reference of where to
get the test file from, ie.
ftp://ftp.unicode.org/Public/UNIDATA/NormalizationTest.txt
Thanks for working on this !
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=626485&group_id=5470