[Patches] [ python-Patches-610522 ] IDLE TODO:left,right when selected text

noreply@sourceforge.net noreply@sourceforge.net
Tue, 17 Sep 2002 07:19:45 -0700


Patches item #610522, was opened at 2002-09-17 15:56
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=610522&group_id=5470

Category: IDLE
Group: Python 2.3
Status: Open
Resolution: None
Priority: 5
Submitted By: Christos Georgiou (tzot)
Assigned to: Nobody/Anonymous (nobody)
Summary: IDLE TODO:left,right when selected text

Initial Comment:
This patch makes sure that when text is selected in an
IDLE editor window, pressing left or right cursor key
moves the caret to the corresponding end of the
selection.
The patch works correctly in Red Hat Linux 6.2 (Python
2.3a0, Tcl/Tk 8.0), Mandrake Linux 8.2 (Python 2.3a0,
Tcl/Tk 8.3), Win2K (Python 2.2.1, Tcl/Tk 8.3), SGI Irix
6.5.17 (Python 2.3a0, Tcl/Tk 8.0).
Please read additional info supplied as the first
comment to this patch.

----------------------------------------------------------------------

>Comment By: Christos Georgiou (tzot)
Date: 2002-09-17 17:19

Message:
Logged In: YES 
user_id=539787

(I hope this does not show as a duplicate, it seems my earlier 
comment did not get posted).

I do not like two things in my patch.

1. Where I did the keyboard bindings 
(EditorWindow.set_status_bar where there were two other 
keyboard bindings).
Anyway, I put the event procedure right after set_status_bar 
so that it can be refactored easily by somebody else.

2. The mask to check whether Shift or Control is pressed with 
Left or Right is hardcoded.  (5 because Shift turns on bit 0, 
Control turns on bit 2).  Although I verified that this applies to 
all the platforms referenced in the patch description, it still 
isn't the Right Thing.  Any hints as to find documentation for 
platform-independent checking of the event.state attribute?
I won't dare to check for Alt modifiers, since the bits turned 
on vary heavily depending on the window server getting the 
keypresses.

----------------------------------------------------------------------

Comment By: Christos Georgiou (tzot)
Date: 2002-09-17 17:19

Message:
Logged In: YES 
user_id=539787

(I hope this does not show as a duplicate, it seems my earlier 
comment did not get posted).

I do not like two things in my patch.

1. Where I did the keyboard bindings 
(EditorWindow.set_status_bar where there were two other 
keyboard bindings).
Anyway, I put the event procedure right after set_status_bar 
so that it can be refactored easily by somebody else.

2. The mask to check whether Shift or Control is pressed with 
Left or Right is hardcoded.  (5 because Shift turns on bit 0, 
Control turns on bit 2).  Although I verified that this applies to 
all the platforms referenced in the patch description, it still 
isn't the Right Thing.  Any hints as to find documentation for 
platform-independent checking of the event.state attribute?
I won't dare to check for Alt modifiers, since the bits turned 
on vary heavily depending on the window server getting the 
keypresses.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=610522&group_id=5470