[Patches] [ python-Patches-613708 ] Add smtplib support for SMTP AUTH LOGIN
noreply@sourceforge.net
noreply@sourceforge.net
Wed, 25 Sep 2002 02:45:28 -0700
Patches item #613708, was opened at 2002-09-24 10:48
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=613708&group_id=5470
Category: Library (Lib)
Group: Python 2.3
>Status: Closed
>Resolution: Duplicate
Priority: 5
Submitted By: Paul Moore (pmoore)
Assigned to: Nobody/Anonymous (nobody)
Summary: Add smtplib support for SMTP AUTH LOGIN
Initial Comment:
Adds support for SMTP AUTH logins using the LOGIN
protocol (in addition to currently supported PLAIN and
CRAM-MD5 options). This is added as a "last resort"
option after the other two, so no change should be
visible against servers supporting either of the two
currently supported methods.
This patch has been tested against a Microsoft
Windows 2000 SMTP server (which supports LOGIN,
but not either of the other two options).
The patch also includes a small change to handle MS
SMTP server (broken???) behaviour in sending a line
AUTH=xxxx line in response to EHLO in addition to the
standard AUTH protocol protocol ... This change simply
changes the feature match regular expression to ignore
feature names followed by anything other than space or
end of line. Alternative approaches could involve
specifically trapping repeated features, and ignoring the
second and subsequent occurrences, or somehow
combining the repeated occurrences. I don't believe that
this adds anything over the simple approach taken in the
patch.
----------------------------------------------------------------------
>Comment By: Paul Moore (pmoore)
Date: 2002-09-25 10:45
Message:
Logged In: YES
user_id=113328
Looks like http://python.org/sf/572031 is a far more thorough
approach. I'm happy to close this patch in favour of that one.
I've set the status to "Closed" and resolution to "duplicate".
BTW, was there a way I could have found the duplicate? I
didn't notice it in the browse list, and I couldn't see a "search"
facility in the patch tracker...
----------------------------------------------------------------------
Comment By: Gerhard Häring (ghaering)
Date: 2002-09-24 19:23
Message:
Logged In: YES
user_id=163326
This part of your code is broken:
(code, resp) = self.docmd(base64.encodestring(password)[:-1])
That's what you get from copy & pasting mine *cough* ;-)
For why it's wrong see this patch:
http://python.org/sf/552605 which I integrated my patch
Martin mentioned and for which I did a Python 2.2 backport,
too. I'd also kindly ask to check it out at
http://python.org/sf/572031 Tested it myself against MS
Exchange, Postfix and qmail so far.
----------------------------------------------------------------------
Comment By: Martin v. Löwis (loewis)
Date: 2002-09-24 17:16
Message:
Logged In: YES
user_id=21627
This appears to be a duplicate of #572031. Can you please
study #572031, and comment whether your patch has features
that the other patch is lacking?
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=613708&group_id=5470