[Patches] [ python-Patches-618791 ] [mingw patches] alloca and posixmodule

SourceForge.net noreply@sourceforge.net
Fri, 11 Apr 2003 18:31:52 -0700


Patches item #618791, was opened at 2002-10-04 19:43
Message generated for change (Comment added) made by nnorwitz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=618791&group_id=5470

Category: Core (C code)
Group: Python 2.3
Status: Open
Resolution: None
Priority: 2
Submitted By: Gerhard Häring (ghaering)
Assigned to: Gerhard Häring (ghaering)
Summary: [mingw patches] alloca and posixmodule

Initial Comment:
This is the first patch in a series of patching of
porting Python to native win32, while still using the
autoconf-based build process. The compiler used is
mingw, the build environment used is msys, a stripped
down Cygwin from the mingw project.

This patch does several things:

* change _alloca to alloca for both mingw and Visual
C++, to avoid unnecessary #ifdef-ing.

* Change the makesetup shell script to work for win32,
where for some weird reason we have a module 'nt' built
from a posixmodule.c file.

* Change on occurence of  #ifdef MS_WINDOWS in
posixmodule.c where it should really have been #ifdef
Py_WIN_WIDE_FILENAMES

* Change the #ifdefs in posixmodule.c so that it can be
built with both MSVC and mingw

The result of this patch is that we can build a
statically built python.exe with a simple
./configure
make
under mingw/msys.

There's, however, still of additional work to do until
we can build a native win32 Python with the
autoconf-based build process.

Please apply this ASAP, as I want to avoid having a
diverging Python tree on my harddisk (this makes patch
creation a lot more difficult).

----------------------------------------------------------------------

>Comment By: Neal Norwitz (nnorwitz)
Date: 2003-04-11 21:31

Message:
Logged In: YES 
user_id=33168

Gerhard, is there any reason to leave this patch open?

----------------------------------------------------------------------

Comment By: Gerhard Häring (ghaering)
Date: 2002-11-05 05:35

Message:
Logged In: YES 
user_id=163326

Cool :-)

I'm assigning this patch to myself now.

----------------------------------------------------------------------

Comment By: Tim Peters (tim_one)
Date: 2002-11-04 22:39

Message:
Logged In: YES 
user_id=31435

Welcome, Gerhard!  You have commit privileges now.  If 
you need any help with SourceForge mechanics, ask on 
Python-Dev and you'll get more advice than you can stand 
<wink>.

----------------------------------------------------------------------

Comment By: Gerhard Häring (ghaering)
Date: 2002-11-04 19:57

Message:
Logged In: YES 
user_id=163326

Sounds great. I'd have needed advice from python-dev anyway,
especially on the parts where autoconf is concerned (I'm
relatively green there).

----------------------------------------------------------------------

Comment By: Guido van Rossum (gvanrossum)
Date: 2002-11-04 15:04

Message:
Logged In: YES 
user_id=6380

What I'd like to see most is for somebody with CVS commit
permission for Python *and* an understanding of mingw to
start making the changes in Python's CVS. I'd be willing to
give you CVS permission for this, if you're willing to work
with python-dev regarding the acceptability of the various
changes you're proposing. I presume you'll quickly get a
sense for what kind of changes are non-controversional and
can be checked in without asking.

----------------------------------------------------------------------

Comment By: Gerhard Häring (ghaering)
Date: 2002-11-04 09:14

Message:
Logged In: YES 
user_id=163326

Guido, if you think that there should either be one big
patch that enables Python to be built with mingw or nothing
at all, then please close this as 'rejected' or whatever.
There are good reasons for doing so, just as there are
arguments for incremental patches, like I described above.

I won't feel offended, especially as I know how annoying it
is for myself to have a SF entry page full of this kind of
patches/bugs :)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=618791&group_id=5470