[Patches] [ python-Patches-725899 ] Cause urllib.urlretrieve() to match docs for local files
SourceForge.net
noreply@sourceforge.net
Tue, 22 Apr 2003 17:27:13 -0700
Patches item #725899, was opened at 2003-04-22 18:27
Message generated for change (Comment added) made by gvanrossum
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=725899&group_id=5470
Category: Library (Lib)
Group: Python 2.3
Status: Open
Resolution: None
Priority: 7
Submitted By: Brett Cannon (bcannon)
Assigned to: Guido van Rossum (gvanrossum)
Summary: Cause urllib.urlretrieve() to match docs for local files
Initial Comment:
As of right now, urllib.urlretrieve() returns an actual
mimetools.Message object for its 'headers' value. Now both the
module doc and doc string say that it should be returning None. I
have a patch here (all 3 lines of it) to cause urlretrive to match the
documentation.
But perhaps we should change the docs instead? I have no clue if
there is any code out in the wild that relies on the current behavior. I
personally say keep the code as it is and fix the docs, but that is just
me.
I am going to hold off on applying this patch until someone else
either agrees with me or I get someone higher up the food chain to
tell me I am wrong. I am going to assign this to Guido initially but I
can apply the patch myself; just need an answer on this before b1
goes out since this patch changes semantics.
----------------------------------------------------------------------
>Comment By: Guido van Rossum (gvanrossum)
Date: 2003-04-22 20:27
Message:
Logged In: YES
user_id=6380
Hm, I don't see you in the list of committers?
----------------------------------------------------------------------
Comment By: Guido van Rossum (gvanrossum)
Date: 2003-04-22 20:25
Message:
Logged In: YES
user_id=6380
In general fixing the docs is much safet than fixing the
code. ;-)
If you submit a doc patch here it'll be applied. (Note that
the docstring is also lying.)
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=725899&group_id=5470