[Patches] [ python-Patches-725904 ] Minor changes to logging

[SourceForge.net]

Patches item #725904, was opened at 2003-04-22 18:37
Message generated for change (Comment added) made by gvanrossum
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=725904&group_id=5470

Category: Library (Lib)
Group: Python 2.3
>Status: Open
Resolution: Accepted
Priority: 7
Submitted By: Vinay Sajip (vsajip)
Assigned to: Neal Norwitz (nnorwitz)
Summary: Minor changes to logging

Initial Comment:
__init__.py:
1. Updated version number to 0.4.8 and status to beta.
handlers.py:
1. Replaced explicit Python version check with hasattr to 
determine the running Python's capability.
2. Added Date: header to SMTPHandler
3. Changed HTTPHandler to allow more flexible mapping 
of a LogRecord to a dictionary to be urlencoded.

Regression test ran OK on my system after these 
changes were made.


----------------------------------------------------------------------

>Comment By: Guido van Rossum (gvanrossum)
Date: 2003-04-23 14:22

Message:
Logged In: YES 
user_id=6380

If adding a small sleep to the code "fixes" the problem,
there is still a more fundamental problem with the tests.
Vinaj, can you look into this? Do you understand the issue?
I wonder if maybe the tests shouldn't be thread-based at all.

It is okay if this doesn't get resolved before the b1
release; there will be a b2 release a month later. (As long
as it doesn't require API changes -- bugfixes or changes to
the test suite are okay though.)

----------------------------------------------------------------------

Comment By: Neal Norwitz (nnorwitz)
Date: 2003-04-22 23:52

Message:
Logged In: YES 
user_id=33168

Checked in as:
 * Lib/logging/__init__.py: 1.9
 * Lib/logging/handlers.py: 1.6

I still have the test failure problem.  It's more consistent
on Redhat 9.  Adding a time.sleep(.1) to the test as the
first statement in the finally: in test_main() (line 458)
"fixes" the problem.  Although this is a hack that I don't
want to check in.

----------------------------------------------------------------------

Comment By: Guido van Rossum (gvanrossum)
Date: 2003-04-22 20:29

Message:
Logged In: YES 
user_id=6380

Unassigning and accepting; someone else please apply this!

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=725904&group_id=5470