[Patches] [ python-Patches-786591 ] test_largefile cleanup patch

[SourceForge.net]

Patches item #786591, was opened at 2003-08-11 03:55
Message generated for change (Comment added) made by jlt63
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=786591&group_id=5470

Category: Tests
Group: Python 2.4
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: Jason Tishler (jlt63)
Assigned to: Jason Tishler (jlt63)
Summary: test_largefile cleanup patch

Initial Comment:
test_largefile can leave its temp file open if one
of many tests fail. On platforms (e.g., Cygwin)
that are "particular" about open files, this will
cause other regression tests that use the same
temp file to fail:

$ ./python.exe -E -tt Lib/test/regrtest.py -l 
test_largefile test_mmap test_mutants 
test_largefile
test test_largefile failed -- got -1794967295L, but 
expected 2500000001L
test_mmap
test test_mmap crashed -- exceptions.IOError: [Errno 
13] Permission denied: '@test'
test_mutants
test test_mutants crashed -- exceptions.IOError: [Errno 
13] Permission denied: '@test'

The attached patch solves this problem by adding
missing "try/finally" blocks.  Note that the
"large" size of this patch is due to many white
space changes -- otherwise, the patch is small.

I tested this patch under Red Hat Linux 8.0 too.

Is someone willing to eyeball this one before I
check it in? Thanks.


----------------------------------------------------------------------

>Comment By: Jason Tishler (jlt63)
Date: 2003-08-26 04:02

Message:
Logged In: YES 
user_id=86216

I guess that the eyeballs didn't find anything or weren't
looking... :,)

Committed on HEAD as Lib/test/test_largefile.py 1.17 and
release23-maint as Lib/test/test_largefile.py 1.16.16.1.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=786591&group_id=5470