[Patches] [ python-Patches-661760 ] Cygwin auto-import module patch

[SourceForge.net]

Patches item #661760, was opened at 2003-01-03 09:14
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=661760&group_id=5470

Category: Modules
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: Jason Tishler (jlt63)
Assigned to: Jason Tishler (jlt63)
Summary: Cygwin auto-import module patch

Initial Comment:
The attached patch enables shared extension
modules to build cleanly under Cygwin without
moving the static initialization of certain function
pointers (i.e., ones exported from the Python
DLL core) to a module initialization function.

Additionally, this patch fixes the modules that
have been changed in the past to accommodate
Cygwin. Specificially, these modules are:

_hotshot.c
_randommodule.c
_tkinter.c
arraymodule.c
bz2module.c
cPickle.c
socketmodule.c

Note that contrary to my recent email to
python-dev, I did *not* make the following
changes:

$ grep '\.tp_.*[ \t]*=' *.c
bz2module.c:    BZ2File_Type.tp_base = &PyFile_Type;
bz2module.c:    BZ2File_Type.tp_new = 
PyFile_Type.tp_new;
posixmodule.c:  StatResultType.tp_new = 
statresult_new;
threadmodule.c: Locktype.tp_doc = lock_doc;
xxsubtype.c:    spamdict_type.tp_base = &PyDict_Type;
xxsubtype.c:    spamlist_type.tp_base = &PyList_Type;


----------------------------------------------------------------------

>Comment By: Jason Tishler (jlt63)
Date: 2003-01-06 03:46

Message:
Logged In: YES 
user_id=86216

Checked in as:

Include/pyport.h 2.58
Modules/_hotshot.c 1.32
Modules/_randommodule.c 1.3
Modules/_tkinter.c 1.146
Modules/arraymodule.c 2.81
Modules/bz2module.c 1.14
Modules/cPickle.c 2.99
Modules/socketmodule.c 1.251

----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2003-01-05 00:53

Message:
Logged In: YES 
user_id=21627

I had missed the fact that --enable-auto-import is enabled
by default. So the patch is fine, please apply it.

----------------------------------------------------------------------

Comment By: Jason Tishler (jlt63)
Date: 2003-01-04 17:56

Message:
Logged In: YES 
user_id=86216

>I'm probably missing some magic here: 

Did you miss the following?

http://mail.python.org/pipermail/python-dev/2003-
January/031703.html

> shouldn't there be a patch to configure.in also
> to provide the necessary linker options?

No, the defaults are sufficient.

Please (re)read the above URL. Let me know if
you need further clarification.

The bottom line is that the patch works correctly
under Cygwin. And, AFAICT, will not break any
other platform.

----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2003-01-03 10:46

Message:
Logged In: YES 
user_id=21627

I'm probably missing some magic here: shouldn't there be a
patch to configure.in also to provide the necessary linker
options?

As for the SF breakage: you should file a bug for SF, in the
"alexandria" project. Perhaps better use a support request,
since that gets better attention.

----------------------------------------------------------------------

Comment By: Jason Tishler (jlt63)
Date: 2003-01-03 09:15

Message:
Logged In: YES 
user_id=86216

AFAICT, SF is still broken! I *did* check the upload
checkbox!

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=661760&group_id=5470