[Patches] [ python-Patches-658599 ] Fix for bug 494589

[SourceForge.net]

Patches item #658599, was opened at 2002-12-26 18:49
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=658599&group_id=5470

Category: Library (Lib)
Group: Python 2.2.x
Status: Open
Resolution: None
Priority: 5
Submitted By: Miki Tebeka (tebeka)
Assigned to: Mark Hammond (mhammond)
Summary: Fix for bug 494589

Initial Comment:
This is a fix for bug 494589 (os.path.expandvars)
I suggest using the same code in ntpath and posixpath.
(Maybe have a commonpath.py and let both import it?)

Python version 2.2.2
OS: NT4 SP6 (checked on NT and cygwin)

Miki

----------------------------------------------------------------------

>Comment By: Mark Hammond (mhammond)
Date: 2003-01-16 16:24

Message:
Logged In: YES 
user_id=14198

It was late last night - the idea of ripping out all
duplicated code wont work.  A consolidation may be possible,
but I haven't time.  I'm deleting that patch, but still
believe that

from posixpath import expandvars

is reasonable.  Comments?

----------------------------------------------------------------------

Comment By: Tim Peters (tim_one)
Date: 2003-01-16 06:14

Message:
Logged In: YES 
user_id=31435

Sounds like an excellent idea to me, Mark!  The glory is all 
yours, if you're man enough to accept it <wink>.

----------------------------------------------------------------------

Comment By: Mark Hammond (mhammond)
Date: 2003-01-15 23:38

Message:
Logged In: YES 
user_id=14198

In fact, why not go the whole-hog, and remove all code in
ntpath.py that is identical to posixpath.py

Example patch attached <wink>

----------------------------------------------------------------------

Comment By: Mark Hammond (mhammond)
Date: 2003-01-15 14:44

Message:
Logged In: YES 
user_id=14198

Is there any reason why:

from posixpath import expandvars

is not a better patch?  From what I can see, posixpath's
version works fine for Windows (windows os.environ is case
insensitive)

----------------------------------------------------------------------

Comment By: Tim Peters (tim_one)
Date: 2003-01-14 04:59

Message:
Logged In: YES 
user_id=31435

Mark, can you make time to look at this?  I can't.

----------------------------------------------------------------------

Comment By: Neal Norwitz (nnorwitz)
Date: 2003-01-04 14:31

Message:
Logged In: YES 
user_id=33168

The patch didn't apply for me, so I created a new one and
attached it.  I can't test this.  Maybe Tim is interested.

----------------------------------------------------------------------

Comment By: Miki Tebeka (tebeka)
Date: 2002-12-29 18:28

Message:
Logged In: YES 
user_id=358087

This time the checkbox is checked. :-)

Miki

----------------------------------------------------------------------

Comment By: Neal Norwitz (nnorwitz)
Date: 2002-12-27 05:07

Message:
Logged In: YES 
user_id=33168

There's no uploaded file!  You have to check the
checkbox labeled "Check to Upload & Attach File"
when you upload a file.

Please try again.

(This is a SourceForge annoyance that we can do
nothing about. :-( )

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=658599&group_id=5470