[Patches] [ python-Patches-770521 ] make itertools type declarations static

[SourceForge.net]

Patches item #770521, was opened at 2003-07-13 08:57
Message generated for change (Settings changed) made by rhettinger
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=770521&group_id=5470

Category: Modules
Group: Python 2.3
Status: Open
>Resolution: Accepted
Priority: 3
Submitted By: Andrew I MacIntyre (aimacintyre)
>Assigned to: Andrew I MacIntyre (aimacintyre)
Summary: make itertools type declarations static

Initial Comment:
the intertools module defines a number of type
structures, which are not declared static.

these structures don't need to be symbolically visible
outside the module, and I think would be better
declared static to reduce namespace pollution.

this became noticeable as I was building itertools in
an external module on OS/2, where these type symbols
were not exported from the external module (DLL) with
no problem.  I changed to building itertools into the
core DLL, and my DLL export machinery started to export
these type symbols.

I've changed the core DLL export definition machinery
to deal with this, so this is a low priority "cleanup"
issue in my view.

Assigned to Raymond, as itertools is his baby.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=770521&group_id=5470