[Patches] [ python-Patches-762934 ] address test_time.py failures under Redhat 6.2

[SourceForge.net]

Patches item #762934, was opened at 2003-06-29 17:44
Message generated for change (Comment added) made by bcannon
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=762934&group_id=5470

Category: Library (Lib)
Group: Python 2.3
Status: Open
Resolution: None
Priority: 5
Submitted By: Stuart Bishop (zenzen)
Assigned to: Brett Cannon (bcannon)
Summary: address test_time.py failures under Redhat 6.2

Initial Comment:
A mangled version of this patch is also in bug:
    http://www.python.org/sf/728051

Looks like tzset(3) is broken under Redhat 6.2 in a way
that wasn't being detected by configure. This
patch adds stricter tzset(3) checking to configure.in.



----------------------------------------------------------------------

>Comment By: Brett Cannon (bcannon)
Date: 2003-07-22 16:04

Message:
Logged In: YES 
user_id=357491

Well, it is looking like tzset_AEST is not working as a solution.  
Hopefully Neal's patch will do the trick.

----------------------------------------------------------------------

Comment By: Neal Norwitz (nnorwitz)
Date: 2003-07-22 15:46

Message:
Logged In: YES 
user_id=33168

See this mail for a possible fix. 
http://mail.python.org/pipermail/python-dev/2003-July/037116.html

Stuart, is that correct?  It fixes the problem on RedHat 6.2
and doesn't break on RedHat 9.  The change is to define YEAR
as 365 * 24 * 3600, instead of adding 6 hours.

----------------------------------------------------------------------

Comment By: Skip Montanaro (montanaro)
Date: 2003-07-16 13:05

Message:
Logged In: YES 
user_id=44345

Works for me (Mac OS X)


----------------------------------------------------------------------

Comment By: Brett Cannon (bcannon)
Date: 2003-07-12 19:27

Message:
Logged In: YES 
user_id=357491

Quick update: I got autoreconf to work and it seems to work for 
me.  I also tested the C code in isolation and had no problems.  So 
I now I just need other people to apply the patch and say whether 
it works.

----------------------------------------------------------------------

Comment By: Brett Cannon (bcannon)
Date: 2003-07-12 16:01

Message:
Logged In: YES 
user_id=357491

Well, it didn't work for two people for Red Hat 6.2 .  Perhaps being 
more explicit for the test?  To give that a shot, I am uploading a 
patch that tests explicitly for AEDT as the daylight-savings 
timezone.  I snagged the code mostly from Modules/timemodule.c 
.

Now this is untested so there could be syntax problems.  I can't 
get a proper version of Autoconf to run on my system so I can run 
autoreconf.  Hopefully this will deal with the problem.

----------------------------------------------------------------------

Comment By: Barry A. Warsaw (bwarsaw)
Date: 2003-07-10 07:29

Message:
Logged In: YES 
user_id=12800

This patch didn't break RH9.

----------------------------------------------------------------------

Comment By: Brett Cannon (bcannon)
Date: 2003-07-03 13:16

Message:
Logged In: YES 
user_id=357491

We can say it should fail under Linux, but we can't specify Red Hat 
6.2.

I am keeping an eye on this patch for bug  #763153, but I have to 
wait until the OP applies it and tests it.

Looking at the patch, beyond not realizing that the X-mas time 
was GMT initially and the unneeded variable assignments, the 
patch looks fine to me (might want to comment that tzset does not 
return a value; rather non-standard) although I am no autoconf 
expert and I am assuming it just compiles this C code and any 
problems it just says  it fails.

Neal, what OS are you  running?  If it is non-OS X (sorry, that's 
what I am running as well) can you give the patch a try?

----------------------------------------------------------------------

Comment By: Stuart Bishop (zenzen)
Date: 2003-07-01 20:51

Message:
Logged In: YES 
user_id=46639

This patch has only been tested under OS X.

I'm confident that it won't break other platforms.

I have no real way of proving that it addresses the problem it is 
supposed to solve, however, as I don't have access to a box that 
fails the tzset test in test_time.py.

The only reported platform that this is failing on is at
http://www.python.org/sf/728051, so we could just flag this
test as expected to fail on that platform, if someone knows how
to do that.

----------------------------------------------------------------------

Comment By: Neal Norwitz (nnorwitz)
Date: 2003-07-01 20:03

Message:
Logged In: YES 
user_id=33168

Stuart, what boxes did you test this on?  How confident are
you that this won't break some other platform?  I'm asking
to try to determine if this should go into 2.3final (we only
have 1 release candidate before release) or if this should
wait for 2.3.1.  Thanks for all your work on tzset.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=762934&group_id=5470