[Patches] [ python-Patches-755245 ] Modernize Lib/posixpath.py
SourceForge.net
noreply@sourceforge.net
Mon, 16 Jun 2003 14:31:40 -0700
Patches item #755245, was opened at 2003-06-16 04:22
Message generated for change (Comment added) made by bcannon
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=755245&group_id=5470
Category: Library (Lib)
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Walter Dörwald (doerwalter)
Assigned to: Brett Cannon (bcannon)
Summary: Modernize Lib/posixpath.py
Initial Comment:
This patch modernizes posixpath: It uses startswith(),
endswith(), rstrip() and struct_passwd attributes.
----------------------------------------------------------------------
>Comment By: Brett Cannon (bcannon)
Date: 2003-06-16 14:31
Message:
Logged In: YES
user_id=357491
Geez, I step out to pick a friend up from the airport and you guys
already revise the thing!
And no, you are not deleting the new version.
----------------------------------------------------------------------
Comment By: Walter Dörwald (doerwalter)
Date: 2003-06-16 12:51
Message:
Logged In: YES
user_id=89016
We could always delete the new version! ;)
----------------------------------------------------------------------
Comment By: Raymond Hettinger (rhettinger)
Date: 2003-06-16 12:44
Message:
Logged In: YES
user_id=80475
You're too quick. Brett was supposed to find that one.
----------------------------------------------------------------------
Comment By: Walter Dörwald (doerwalter)
Date: 2003-06-16 12:39
Message:
Logged In: YES
user_id=89016
There is missing += update in expandvars(). Uploading new
version of the patch
----------------------------------------------------------------------
Comment By: Raymond Hettinger (rhettinger)
Date: 2003-06-16 12:13
Message:
Logged In: YES
user_id=80475
Yes. I've already checked it but wanted you to see the
process of how it can be done reliably (clear objectives,
single module changes, expanded tests, detailed second
party review, etc).
It should take less than half an hour and it's good for you
(like vitamins).
BTW, don't accept the patch until the new test suite runs on
all platforms.
----------------------------------------------------------------------
Comment By: Brett Cannon (bcannon)
Date: 2003-06-16 11:22
Message:
Logged In: YES
user_id=357491
You sure you want me to check this after what happened last
time I tried to "modernize" a module? =)
OK, I will take a look.
----------------------------------------------------------------------
Comment By: Raymond Hettinger (rhettinger)
Date: 2003-06-16 09:01
Message:
Logged In: YES
user_id=80475
Assigning to Brett to give experience doing a detail review on
this type of change.
* examine every line of the diff and consider whether there is
any semantic change (exceptions raised, etc).
* apply the diff and run the test suite
* in the interactive mode, call-up each function and make
sure it behaves as expected (this is necessary because the
test coverage is very low).
* verify that the whitespace has been cleaned up.
* look for missing changes (such as use of +=)
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=755245&group_id=5470