[Patches] [ python-Patches-736413 ] DESTDIR improvement

SourceForge.net noreply@sourceforge.net
Thu, 26 Jun 2003 06:44:49 -0700


Patches item #736413, was opened at 2003-05-12 12:30
Message generated for change (Comment added) made by nijel
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=736413&group_id=5470

Category: Build
Group: Python 2.3
Status: Closed
Resolution: Rejected
Priority: 5
Submitted By: Michal Čihař (nijel)
Assigned to: Nobody/Anonymous (nobody)
Summary: DESTDIR improvement

Initial Comment:
Byte compile correctly with DESTDIR.

----------------------------------------------------------------------

>Comment By: Michal Čihař (nijel)
Date: 2003-06-26 15:44

Message:
Logged In: YES 
user_id=192186

Yes, you're right, sorry for posting bad patch....

----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2003-06-21 15:27

Message:
Logged In: YES 
user_id=21627

The patch is incorrect: setting -d to DESTDIR will cause
DESTDIR to be hard-coded. Correct is to use LIBDEST,
committed as Makefile.pre.in 1.134

----------------------------------------------------------------------

Comment By: Michal Čihař (nijel)
Date: 2003-05-19 11:51

Message:
Logged In: YES 
user_id=192186

I forgot to mention, that the patch was larger before, but I
saw many simmilar things applied in CVS, so this _should_
work with CVS version. However I will test it today...

----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2003-05-16 23:42

Message:
Logged In: YES 
user_id=21627

Please test this on your machine. The byte code of
__init__.py will still point to 

/home/users/user/tmp/python-2.3b1-root-user/usr/lib/python2.3/logging/__init__.py

with your patch applied.

----------------------------------------------------------------------

Comment By: wrobell (wrobell)
Date: 2003-05-16 10:52

Message:
Logged In: YES 
user_id=387193

A simple test, to describe the problem, below.

DESTDIR is set to "/home/users/user/tmp/python-2.3b1-root-user".
-----------------
import logging
 
class X:
    pass
 
logging.setLoggerClass(X)
-------------------

Code above gives following exception:

Traceback (most recent call last):
  File "tracedir.py", line 6, in ?
    logging.setLoggerClass(X)
  File
"/home/users/user/tmp/python-2.3b1-root-user/usr/lib/python2.3/logging/__init__.py",
line 729, in setLoggerClass
TypeError: logger not derived from logging.Logger: X

I _suppose_ that, after applying the patch the exception
will look like:

Traceback (most recent call last):
  File "tracedir.py", line 6, in ?
    logging.setLoggerClass(X)
  File "/usr/lib/python2.3/logging/__init__.py", line 729,
in setLoggerClass
TypeError: logger not derived from logging.Logger: X

There will be no DESTDIR part in the module filepath.

----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2003-05-16 08:09

Message:
Logged In: YES 
user_id=21627

What is the rationale of this patch? If I set DESTDIR to,
say, /tmp/py, why is passing -d /tmp/py to compileall desirable?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=736413&group_id=5470