[Patches] [ python-Patches-761969 ] -DPIC should be added for the -fPIC case

SourceForge.net noreply@sourceforge.net
Mon, 30 Jun 2003 03:30:42 -0700


Patches item #761969, was opened at 2003-06-28 03:22
Message generated for change (Comment added) made by aimacintyre
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=761969&group_id=5470

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Marc Recht (marc)
Assigned to: Nobody/Anonymous (nobody)
Summary: -DPIC should be added for the -fPIC case

Initial Comment:
AFAIK -DPIC should always added when compiling with
-DPIC.  At least that's what libtool does and shown in
many FAQs (like
http://www.netbsd.org/Documentation/elf.html).
A quick glance on NetBSD-current and FreeBSD (4.8)
shows that it's evaluated in machine/asm.h.

----------------------------------------------------------------------

>Comment By: Andrew I MacIntyre (aimacintyre)
Date: 2003-06-30 20:30

Message:
Logged In: YES 
user_id=250749

I tested this patch on both FreeBSD 48 & 5.1.

AFAICT, this did not affect behaviour of the interpreter
either way.

I note that you've tagged quite a few platforms in this
patch, thus it would need to be tested on all affected
platforms to be accepted in full.

At this time, it isn't clear to me what benefits this patch
gets us.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=761969&group_id=5470