[Patches] [ python-Patches-701494 ] more apply removals

SourceForge.net noreply@sourceforge.net
Thu, 20 Mar 2003 07:26:53 -0800


Patches item #701494, was opened at 2003-03-11 13:32
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=701494&group_id=5470

Category: Library (Lib)
Group: Python 2.3
Status: Open
Resolution: None
Priority: 5
Submitted By: Christos Georgiou (tzot)
>Assigned to: Raymond Hettinger (rhettinger)
Summary: more apply removals

Initial Comment:
More apply() removals from the following files:
./compiler/transformer.py
./curses/wrapper.py
./distutils/command/build_ext.py
./distutils/command/build_py.py
./distutils/archive_util.py
./distutils/dir_util.py
./distutils/filelist.py
./distutils/util.py
./bsddb/test/test_basics.py
./bsddb/test/test_dbobj.py
./bsddb/dbobj.py
./bsddb/dbshelve.py
./lib-tk/Canvas.py
./lib-tk/Dialog.py
./lib-tk/ScrolledText.py
./lib-tk/Tix.py
./lib-tk/Tkinter.py
./lib-tk/tkColorChooser.py
./lib-tk/tkCommonDialog.py
./lib-tk/tkFont.py
./lib-tk/tkMessageBox.py
./lib-tk/tkSimpleDialog.py
./lib-tk/turtle.py
./test/reperf.py
./test/test_b1.py
./test/test_builtin.py
./test/test_curses.py
./logging/__init__.py
./logging/config.py
./xml/dom/minidom.py
./plat-mac/Carbon/MediaDescr.py
./plat-mac/EasyDialogs.py
./plat-mac/FrameWork.py
./plat-mac/MiniAEFrame.py
./plat-mac/argvemulator.py
./plat-mac/icopen.py

I know that the edited files are syntactically correct (ie 
compileall.compile_dir throws no errors), but please help 
testing that functionality is the same.  I am testing at 
the moment for lib-tk changes.

----------------------------------------------------------------------

>Comment By: Walter Dörwald (doerwalter)
Date: 2003-03-20 16:26

Message:
Logged In: YES 
user_id=89016

I've gone over the patch and simplyfied it a bit (e.g.
replacing f(*(1,2,3) + args) with f(1,2,3, *args)). I've
also removed the patches for distutils, logging and bsddb
(code at the start of bsddb/dbutils.py seems to indicate
that it should be usable with versions prior to 2.3).

Raymond, do you have time to recheck the patch?

----------------------------------------------------------------------

Comment By: Christos Georgiou (tzot)
Date: 2003-03-12 09:46

Message:
Logged In: YES 
user_id=539787

Walter: I untargzipped the python-latest.tgz of 2003-03-10 
over an older directory (I think about a month ago), therefore 
the existence of test_b1.py.  All files that exist in the current 
dist were also current.
Raymond: you are correct about my not reading the file 
headers (it was a multifile vi session with a +/"apply(" 
option...)
I just had a little time available for non-creative work, so I 
checked, saw that Guido already had changed most of the 
library files, and offered the change of the rest of them; you 
guys can do whatever you want with it :)
The lib-tk changes seem to be ok, after running some UI 
python scripts I have.  I haven't checked bsddb yet.

----------------------------------------------------------------------

Comment By: Raymond Hettinger (rhettinger)
Date: 2003-03-12 02:41

Message:
Logged In: YES 
user_id=80475

Also, be sure to read the PEP on which modules should 
not be modernized.  Sometimes that information is written 
in the file itself rather than the pep.  For instance, the 
logging package is supposed to be kept in a form that 
runs on older pythons.

----------------------------------------------------------------------

Comment By: Walter Dörwald (doerwalter)
Date: 2003-03-11 19:34

Message:
Logged In: YES 
user_id=89016

There is no longer a test/test_b1.py in current CVS, so it
seems you've done the diff against an older version. Could
you update the patch for current CVS?

Also according to PEP 291
(http://www.python.org/peps/pep-0291.html) both distutils
and logging should remain 1.5.2 compatible.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=701494&group_id=5470