[Patches] [ python-Patches-658316 ] skips.txt for regrtest.py

SourceForge.net noreply@sourceforge.net
Thu, 08 May 2003 17:46:00 -0700


Patches item #658316, was opened at 2002-12-24 12:03
Message generated for change (Comment added) made by bcannon
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=658316&group_id=5470

Category: Tests
Group: Python 2.3
Status: Open
Resolution: None
Priority: 5
Submitted By: Brett Cannon (bcannon)
Assigned to: Brett Cannon (bcannon)
Summary: skips.txt for regrtest.py

Initial Comment:
As I promised on python-dev here is the functionality
to have  a skips.txt file for regrtest.py.  If the file
is present in the current directory it is parsed (using
the exact same code as used for  the -f option for
regrtest; good, old copy-n-paste) and all tests are
added to the expected skip set.

And as commented in the file, the name of the file is
so named after Skip Montanaro because he is too shy.

----------------------------------------------------------------------

>Comment By: Brett Cannon (bcannon)
Date: 2003-05-08 17:46

Message:
Logged In: YES 
user_id=357491

OK, I am uploading a new patch but now it prints out if a test was not 
executed and then listed all the tests not executed.  This is for several 
reasons.  One is so you don't forget you have a skips.txt file and what tests 
are in it.  You also don't get any possible confusion on why the test was not 
listed while the tests are being executed or if it was printed that it was 
actually run and passed.

I also factored out the file parsing code used by the -f option to the function 
parsefile and use it for both -f and for parsing skips.txt .

Can someone please just take a quick look and tell me that the "not 
executed" statements are reasonable?  If someone gives me the all-clear I 
will apply the patch.

----------------------------------------------------------------------

Comment By: Brett Cannon (bcannon)
Date: 2003-04-23 15:27

Message:
Logged In: YES 
user_id=357491

=)  Sure thing.  Noticed it was assigned to me and everything.  Just need to 
add one feature; I want it to print out what tests were specifically skipped 
because of the skips.txt file so people don't forget that they have tests being 
skipped because of what they have in the file.

----------------------------------------------------------------------

Comment By: Raymond Hettinger (rhettinger)
Date: 2003-04-23 11:33

Message:
Logged In: YES 
user_id=80475

It is time to exercise your new commit priviledges.

----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2003-03-30 13:15

Message:
Logged In: YES 
user_id=21627

Raymond, any further comments?

----------------------------------------------------------------------

Comment By: Brett Cannon (bcannon)
Date: 2002-12-29 17:37

Message:
Logged In: YES 
user_id=357491

Oops.  =)

New diff includes a paragraph at the end of the module
documentation that mentions how to use the new functionality.

Please delete the old diff.

----------------------------------------------------------------------

Comment By: Raymond Hettinger (rhettinger)
Date: 2002-12-28 21:09

Message:
Logged In: YES 
user_id=80475

The patch looks good.
Now, it needs documentation.

----------------------------------------------------------------------

Comment By: Brett Cannon (bcannon)
Date: 2002-12-26 13:04

Message:
Logged In: YES 
user_id=357491

Sorry about that!  I could have sworn I checked the box.  I
have uploaded enough files here you would think it would be
habitual by now.

----------------------------------------------------------------------

Comment By: Neal Norwitz (nnorwitz)
Date: 2002-12-26 10:10

Message:
Logged In: YES 
user_id=33168

There's no uploaded file!  You have to check the
checkbox labeled "Check to Upload & Attach File"
when you upload a file.

Please try again.

(This is a SourceForge annoyance that we can do
nothing about. :-( )

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=658316&group_id=5470