[Patches] [ python-Patches-755677 ] 755617: better docs for os.chmod

SourceForge.net noreply at sourceforge.net
Tue Nov 18 15:08:43 EST 2003


Patches item #755677, was opened at 2003-06-17 05:35
Message generated for change (Comment added) made by loewis
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=755677&group_id=5470

Category: Documentation
Group: Python 2.3
>Status: Closed
>Resolution: Rejected
Priority: 5
Submitted By: Christopher Blunck (blunck2)
Assigned to: Martin v. Löwis (loewis)
Summary: 755617: better docs for os.chmod

Initial Comment:
As per the discussion thread on c.l.p and summarized by
Matthew Shomphe



----------------------------------------------------------------------

>Comment By: Martin v. Löwis (loewis)
Date: 2003-11-18 21:08

Message:
Logged In: YES 
user_id=21627

I'm rejecting the patch on ground that it does not actually
fix the bug.

----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2003-10-18 11:43

Message:
Logged In: YES 
user_id=21627

blunck2, are you willing to revise the patch in the
indicated direction, i.e. document the real semantics of
os.chmod on Windows, while keeping the material which
primarily applies to Unix?

----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2003-09-20 18:04

Message:
Logged In: YES 
user_id=21627

I don't think that patch fixes the bug - IMO, the
description of mode gets worse, not better, with this patch:
1. The mode is *not* a "four-digit number". It is a plain
integer instead. Some people find it convenient to write
this number in base8, using Python's octal number notation.

2. Other people find it convenient to use a symbolic bit
mask to compute the number. Your patch removes the listing
of the possible symbolic constants, which is bad.

3. You fail to mention some of the bits (e.g. the s-bits)
which are available in the current documentation.

4. The patch fails to address the platform differences which
atleast logistix considers important, in his comment to #755617

----------------------------------------------------------------------

Comment By: Christopher Blunck (blunck2)
Date: 2003-06-23 15:12

Message:
Logged In: YES 
user_id=531881

Sure-

According to the discussion here:
http://groups.google.com/groups?hl=en&lr=&ie=UTF-8&threadm=mailman.1055808030.15325.python-list%40python.org&rnum=1&prev=/groups%3Fq%3Dos.chmod%2Bgroup:comp.lang.python.*%26hl%3Den%26lr%3D%26ie%3DUTF-8%26group%3Dcomp.lang.python.*%26selm%3Dmailman.1055808030.15325.python-list%2540python.org%26rnum%3D1

there was confusion as the behavior of os.chmod() on
non-Unix platforms.  Discussion led to a recommendation for
a documentation change, which was submitted as an attachment
to the bug report located here:
http://www.python.org/sf/755617

The submitter of the bug report didn't know how to submit a
patch.  I decided to capture the documentation, add it to
the appropriate tex file, produce a patch, and submit it to sf.

----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2003-06-21 15:33

Message:
Logged In: YES 
user_id=21627

Can you give the rationale for this change, for those of us
that don't know which thread you are referring to?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=755677&group_id=5470



More information about the Patches mailing list