[Patches] [ python-Patches-707167 ] fix bug #682813: dircache.listdir doesn't signal error

SourceForge.net noreply at sourceforge.net
Sat Sep 20 11:54:16 EDT 2003


Patches item #707167, was opened at 2003-03-20 23:13
Message generated for change (Comment added) made by loewis
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=707167&group_id=5470

Category: Library (Lib)
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 5
Submitted By: Michael Stone (mbrierst)
Assigned to: Martin v. Löwis (loewis)
Summary: fix bug #682813: dircache.listdir doesn't signal error

Initial Comment:


Attached small patch makes dircache.listdir

raise OSError when encountered in

os.stat or os.listdir.  This certainly seems

like the right thing to do to be consistent

with os.listdir, though there may have been

a reason not to raise the exception I don't know

about, as it is obviously being purposefully caught

right now.  If there is a reason, someone let me

know and I'll submit a patch to change dircache's

documentation to reflect its behavior.



The test case is also updated by the patch.

----------------------------------------------------------------------

>Comment By: Martin v. Löwis (loewis)
Date: 2003-09-20 17:54

Message:
Logged In: YES 
user_id=21627

Thanks for the patch; I have committed it as



whatsnew24.tex 1.3

dircache.py 1.12

test_dircache.py 1.6

NEWS 1.857



I will not backport it to 2.3 or earlier, because that is a

behaviour change.

----------------------------------------------------------------------

Comment By: Brett Cannon (bcannon)
Date: 2003-03-21 03:03

Message:
Logged In: YES 
user_id=357491

Patch looks good.



Don't let the wording in the description mislead you, though.  No exception is specifically raised; it just is not caught anymore.



As for whether this patch should be applied or not I have no clue since I never use the module.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=707167&group_id=5470



More information about the Patches mailing list