[Patches] [ python-Patches-997626 ] httplib.HTTPConnection.request() bug

[SourceForge.net]

Patches item #997626, was opened at 2004-07-25 17:56
Message generated for change (Settings changed) made by jhylton
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=997626&group_id=5470

Category: Library (Lib)
Group: Python 2.4
>Status: Closed
>Resolution: Fixed
Priority: 7
Submitted By: John J Lee (jjlee)
Assigned to: Jeremy Hylton (jhylton)
Summary: httplib.HTTPConnection.request() bug

Initial Comment:
996159 reveals a problem with 
httplib.HTTPConnection.request().

The underlying problem is that, while this method checks 
no explicit Host: header was provided, it fails to do the 
same for Accept-Encoding: and Content-Length:

This patch fixes that.


----------------------------------------------------------------------

Comment By: John J Lee (jjlee)
Date: 2004-07-27 19:55

Message:
Logged In: YES 
user_id=261020

OK, I have now tested my patch, and uploaded a new one which
is syntactically correct ;-) along with a patch for the test
I added to test_httplib.py.

No doc changes are required.


----------------------------------------------------------------------

Comment By: John J Lee (jjlee)
Date: 2004-07-25 18:09

Message:
Logged In: YES 
user_id=261020

Of course, urllib2 should also be fixed not to add Host and 
Content-Length headers (httplib makes a better job of it), but 
that's a separate bug which I'll file separately.


----------------------------------------------------------------------

Comment By: John J Lee (jjlee)
Date: 2004-07-25 18:00

Message:
Logged In: YES 
user_id=261020

This is important to get into 2.4, because it breaks urllib2.

I haven't run the tests yet, or done any manual tests.  I'll try 
and do that tomorrow.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=997626&group_id=5470