[Patches] [ python-Patches-1028908 ] Changes to cookielib.py & friends for 2.4b1

[SourceForge.net]

Patches item #1028908, was opened at 2004-09-16 00:19
Message generated for change (Comment added) made by jhylton
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1028908&group_id=5470

Category: Library (Lib)
Group: Python 2.4
Status: Open
Resolution: None
Priority: 5
Submitted By: John J Lee (jjlee)
Assigned to: Jeremy Hylton (jhylton)
Summary: Changes to cookielib.py & friends for 2.4b1

Initial Comment:
The patch contains uncontroversial changes to cookielib
and associated modules, documentation and tests.  Would
be unfortunate not to have these in 2.4.0.

1. Changes to keep cookielib in sync with ClientCookie
1.0 release.  This will make life simpler for people
migrating from ClientCookie (the package from whence
cookielib, and some recent urllib2 changes, came).

  a. Moved country-code pseudo-top-level domain (eg.
.co.uk) code into a separate method of
DefaultCookiePolicy to make life easier for subclassers
(.set_ok_countrycode_domain()).

  b. Added Cookie.nonstandard_attr_keys() method.

2. Added a new test.

3. Documentation corrections and clarifications
(including adding a prominent warning about current
lack of thread-safety, and a new example).

4. Small-scale refactoring in cookielib.py (including
moving magic_re to its rightful place in _LWPCookieJar.py).

5. Tiny code clarification in urllib2.py.

6. Removed coding declaration from test_cookielib.py,
in favour of escape sequences, since I discovered that
I don't understand coding declarations :-/


----------------------------------------------------------------------

>Comment By: Jeremy Hylton (jhylton)
Date: 2004-12-22 14:41

Message:
Logged In: YES 
user_id=31392

Is it safe to add these as bug fixes for 2.4.1?  It looks
okay to me, but I wanted to be sure that wasn't some API
change that was signficant.


----------------------------------------------------------------------

Comment By: Titus Brown (titus)
Date: 2004-12-19 07:35

Message:
Logged In: YES 
user_id=23486

Applied patch & ran 'make test' under Linux with latest from CVS.  
Everything works.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1028908&group_id=5470