[Patches] [ python-Patches-870606 ] make test_urllib2 work on Windows

[SourceForge.net]

Patches item #870606, was opened at 2004-01-04 18:48
Message generated for change (Comment added) made by jimjjewett
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=870606&group_id=5470

Category: Tests
Group: Python 2.4
Status: Open
Resolution: None
Priority: 5
Submitted By: John J Lee (jjlee)
Assigned to: Jeremy Hylton (jhylton)
Summary: make test_urllib2 work on Windows

Initial Comment:
This fixes HandlerTests.test_file() on Windows.  Hope it 
works -- I don't have 2.4 CVS on Windows. 
 
Also cleaned up testing of generated Last-Modified 
header. 
 
Still needs testing on Mac. 
 
I had to introduce a sanepathname2url() to replace 
urllib.pathname2url().  I don't understand why 
urllib.pathname2url() behaves as it does (returning a path 
starting with three slashes /// instead of one) -- seems 
wrong according to RFC 1738.  Should it be fixed in 
urllib? 

----------------------------------------------------------------------

Comment By: Jim Jewett (jimjjewett)
Date: 2004-01-08 16:03

Message:
Logged In: YES 
user_id=764593

Today, a missing host or protocol indicates a relative URL.  At 
one point, it could also have meant file (or ftp) to the 
localhost.

proto://host/path -> file://localhost/path -> //localhost/path 
-> ///path

Therefore, ///path == //localhost/path, which may well be 
different from BASEURI/path.  

Note that on unix, /path is well-defined, but on windows, it 
isn't.  It should probably map to C:\path, unless there is 
already a driver letter in path -- and I believe that old enough 
browsers supported paths with or without a driver letter.

I do not know what the Mac equivalent of /path should be.  

I suspect the least bad choice for /// is to keep doing 
whatever it did before.



----------------------------------------------------------------------

Comment By: Tim Peters (tim_one)
Date: 2004-01-04 18:58

Message:
Logged In: YES 
user_id=31435

I confirm that the patch allows test_urllib2 to pass again on 
Windows.  Assigned to Jeremy, as I made no attempt to try 
to understand what the patch does.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=870606&group_id=5470