[Patches] [ python-Patches-873597 ] The cjkcodecs integration

[SourceForge.net]

Patches item #873597, was opened at 2004-01-09 08:55
Message generated for change (Comment added) made by loewis
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=873597&group_id=5470

Category: Library (Lib)
Group: Python 2.4
Status: Open
>Resolution: Accepted
Priority: 5
Submitted By: Hye-Shik Chang (perky)
>Assigned to: Hye-Shik Chang (perky)
Summary: The cjkcodecs integration

Initial Comment:
(finally :)

CJKCodecs includes support for many East Asian legacy
encodings:

* Chinese (PRC): gb2312 gbk gb18030 hz
* Chinese (ROC): big5 cp950
* Japanese: cp932 shift-jis shift-jisx0213 euc-jp
euc-jisx0213 iso-2022-jp iso-2022-jp-1 iso-2022-jp-2
iso-2022-jp-3 iso-2022-jp-ext
* Korean: cp949 euc-kr johab iso-2022-kr

CJKCodecs integration to main python will make CJK
users more comfortable with the default installation
package.

And it's not as big as you might guess. :)

It bloats only 2% by source size:

% du -d0 -k python
37714   python
% du -d0 -k python+cjkcodecs
38504   python+cjkcodecs

And it bloats only 4% by source lines:

% echo `find python.cjkcodecs -type f -exec cat {}
\;|wc -l` "*100/" `find python -type f -exec cat {}
\;|wc -l` "-100" | bc
4


----------------------------------------------------------------------

>Comment By: Martin v. Löwis (loewis)
Date: 2004-01-09 22:24

Message:
Logged In: YES 
user_id=21627

These changes look good to me, please apply them.

As for the regrtest modification, please change the tests to
provide a skip_expected setting, which is computed depending
on the presence of the test data - see test_normalization.py
for an example.

It would be good if the header files containing large tables
would contain an indication on how these tables have been
created (e.g. what data source have been used, and what
modification had been applied after the tables where created
from the sources).

----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2004-01-09 22:10

Message:
Logged In: YES 
user_id=21627

Can you please make that server report the file type as
application/octet-stream?

----------------------------------------------------------------------

Comment By: Hye-Shik Chang (perky)
Date: 2004-01-09 09:00

Message:
Logged In: YES 
user_id=55188

Hmm. SF seems not to accept big patches. (385KB)
I uploaded the patch to
http://people.freebsd.org/~perky/pythoncjkcodecs.diff.bz2 

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=873597&group_id=5470