[Patches] [ python-Patches-988504 ] urllib2.AbstractHTTPHandler broken

[SourceForge.net]

Patches item #988504, was opened at 2004-07-10 11:28
Message generated for change (Comment added) made by akuchling
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=988504&group_id=5470

Category: None
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 7
Submitted By: John J Lee (jjlee)
>Assigned to: A.M. Kuchling (akuchling)
Summary: urllib2.AbstractHTTPHandler broken

Initial Comment:
urllib2.AbstractHTTPHandler lost half of a change that
went in with patch 852995 in 1.57.  The attached patch
fixes it again.

Jeremy removed half of that change in 1.63.  Looks like
he mistakenly thought it was a bug he introduced in
1.59.  In fact, the change introduced in 1.63 broke
HTTP error handling.  To reproduce the bug, run the
tests at the end of urllib2.py

The issue is that AbstractHTTPHandler no longer handles
HTTP errors.  HTTPErrorProcessor does that now.

Seems nobody remembers to run those tests.  I wonder
again whether at least some of them should live in the
main test suite.


----------------------------------------------------------------------

>Comment By: A.M. Kuchling (akuchling)
Date: 2004-07-10 11:35

Message:
Logged In: YES 
user_id=11375

Checked into CVS HEAD; thanks!


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=988504&group_id=5470