[Patches] [ python-Patches-846659 ] fix for bug #812325 (tarfile violates bufsize)

[SourceForge.net]

Patches item #846659, was opened at 2003-11-21 10:53
Message generated for change (Comment added) made by nnorwitz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=846659&group_id=5470

Category: Library (Lib)
>Group: Python 2.4
>Status: Closed
>Resolution: Accepted
Priority: 5
Submitted By: Lars Gustäbel (gustaebel)
>Assigned to: Neal Norwitz (nnorwitz)
Summary: fix for bug #812325 (tarfile violates bufsize)

Initial Comment:
The attached patch fixes an error in the code for GNU
longname/longlink creation. An additional GNU header
block is added to the tar file but not summed up to the
internal counter (self.offset). On close() the
zeropadding is miscalculated which leads to blocksize
violation at the end of the archive.
I had a conversation with Johan Fredrik Öhman (johanfo)
who reported bug #812325 and he told me that my patch
solved his problems.

----------------------------------------------------------------------

>Comment By: Neal Norwitz (nnorwitz)
Date: 2004-07-20 17:55

Message:
Logged In: YES 
user_id=33168

Sorry it took so long.

Checking in:
 * Lib/tarfile.py; 1.12
 * Lib/test/test_tarfile.py; 1.12
 * Misc/NEWS; 1.1047


----------------------------------------------------------------------

Comment By: Lars Gustäbel (gustaebel)
Date: 2004-07-12 04:49

Message:
Logged In: YES 
user_id=642936

Are there any chances to have this patch (and probably the
other pending tarfile patches) applied for the next release?

----------------------------------------------------------------------

Comment By: Lars Gustäbel (gustaebel)
Date: 2004-02-25 14:12

Message:
Logged In: YES 
user_id=642936

This is now the complete final patchset:

- fixes bug #812325.
- fixes the second bug in _create_gnulong() I discovered.
- adds a testcase for GNUlong extensions.
- reverses a patch by A.M. Kuchling which addresses bug
#812325 but which is unnecessary.

----------------------------------------------------------------------

Comment By: Neal Norwitz (nnorwitz)
Date: 2003-12-21 23:35

Message:
Logged In: YES 
user_id=33168

More tests are always good. :-)  I'll try to take a look at
this later, or if someone else checks in that's fine too. 
Also, if I don't get to this, feel free to add the tests to
this patch.  Thanks.

----------------------------------------------------------------------

Comment By: Lars Gustäbel (gustaebel)
Date: 2003-12-16 09:18

Message:
Logged In: YES 
user_id=642936

I must admit, that longnames/longlinks haven't been covered
at all by the test suite until now. Shame on me :-(
So I'm working on some general testcases right now.
While writing the tests, I discovered yet another bug in the
longname creation code that must be fixed. Shame on me again
:-((

If you agree, Neal, I will submit a second patch that
eliminates this new bug and includes a complete set of test
cases for both bugs.


----------------------------------------------------------------------

Comment By: Neal Norwitz (nnorwitz)
Date: 2003-12-14 10:14

Message:
Logged In: YES 
user_id=33168

Lars, could you add a test case for this as well?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=846659&group_id=5470