[Patches] [ python-Patches-980082 ] Missing INCREF in PyType_Ready

[SourceForge.net]

Patches item #980082, was opened at 2004-06-26 01:37
Message generated for change (Comment added) made by mwh
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=980082&group_id=5470

Category: Core (C code)
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Eric Huss (ehuss)
Assigned to: Nobody/Anonymous (nobody)
Summary: Missing INCREF in PyType_Ready

Initial Comment:
In PyType_Ready() if the type object you are readying 
does not explicitly define its tp_base value, it will 
default to use PyBaseObject_Type.

However, this assignment does not INCREF the 
PyBaseObject_Type pointer.  Thus, for heap allocated 
type objects, when the type_dealloc() function is 
called, a DECREF is called on tp_base which can 
eventually cause PyBaseObject_Type refcount go to 0, 
at which point bad things happen.


----------------------------------------------------------------------

>Comment By: Michael Hudson (mwh)
Date: 2004-06-29 17:06

Message:
Logged In: YES 
user_id=6656

I'm not sure this is actually a real problem.  I don't think
you can get into the "base == NULL" case with a heap type...

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=980082&group_id=5470