[Patches] [ python-Patches-901369 ] markupbase misses comments (bug 736659)

[SourceForge.net]

Patches item #901369, was opened at 2004-02-20 15:58
Message generated for change (Comment added) made by fdrake
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=901369&group_id=5470

Category: Library (Lib)
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Jim Jewett (jimjjewett)
Assigned to: Fred L. Drake, Jr. (fdrake)
Summary: markupbase misses comments (bug 736659)

Initial Comment:
markupbase.ParserBase().parse_declaration calls 
parse_comment if the text starts with "<!--" -- except 
that if the text starts with "<!-" it has already 
shortcircuited, thinking it has a short buffer.

Change is just a single character - to ask if the first *2* 
characters are "" or "-" instead of the first *1*.


----------------------------------------------------------------------

>Comment By: Fred L. Drake, Jr. (fdrake)
Date: 2004-09-08 23:54

Message:
Logged In: YES 
user_id=3066

markupbase is currently undocumented and (probably) should
not be used directly.  The concrete subclasses of
markupbase.ParserBase (sgmllib.SGMLParser and
HTMLParser.HTMLParser) handle comments properly because
comments are not handled using parse_declaration().

I've added tests for the concrete subclasses to make sure
they do the right thing with comments crossing buffer
bonudaries.

Since markupbase is currently undocumented and not complete
by itself, I think the right thing to do is clarify in the
markupbase source that it isn't intended to be used directly.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=901369&group_id=5470