[Patches] [ python-Patches-805626 ] make test_fcntl 64bit clean

SourceForge.net noreply at sourceforge.net
Fri Sep 10 08:14:56 CEST 2004


Patches item #805626, was opened at 2003-09-13 16:54
Message generated for change (Comment added) made by loewis
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=805626&group_id=5470

Category: None
Group: None
>Status: Closed
>Resolution: Rejected
Priority: 5
Submitted By: Marc Recht (marc)
Assigned to: Nobody/Anonymous (nobody)
Summary: make test_fcntl 64bit clean

Initial Comment:
Patch to make test_fcntl.py 64bit clean (from NetBSD's
pkgsrc)

The patch is against release23-maint.

Note: I'm not the original autor of this patch. I have
permission to submit it, though.

----------------------------------------------------------------------

>Comment By: Martin v. Löwis (loewis)
Date: 2004-09-10 08:14

Message:
Logged In: YES 
user_id=21627

Rejecting the patch because lack of feedback.

----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2003-09-19 00:49

Message:
Logged In: YES 
user_id=21627

The Alpha version likely runs fine because it is a 64-bit
system, so they use all 8 bytes of the padding (even if in a
different order then the original layout - I assume the
structure definition is completely different from the one
for 32-bit systems?)

I'm mostly concerned about OS X, and perhaps other PPC
systems, as well as 32-bit SPARC. 

It would be good if you could report the *BSD definitions of
the structure on various architectures.

----------------------------------------------------------------------

Comment By: Marc Recht (marc)
Date: 2003-09-18 23:55

Message:
Logged In: YES 
user_id=205

To be honest, I'm not sure. It is tested on Alpha on NetBSD,
though. 
And it is in "pkgsrc" for quite some time now and noone
filed a PR. (But this could also mean that just nobody runs
the tests..)

----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2003-09-18 20:48

Message:
Logged In: YES 
user_id=21627

Does the patch work on all systems? For both byte orders? On
both 32-bit and 64-bit systems?

I'm particularly concerned about big-endian 32-bit systems,
as the padding apparently is intended for little-endian
systems only.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=805626&group_id=5470


More information about the Patches mailing list