[Patches] [ python-Patches-1102879 ] Fix for 926423: socket timeouts + Ctrl-C don't play nice

[SourceForge.net]

Patches item #1102879, was opened at 2005-01-15 12:37
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1102879&group_id=5470

Category: Modules
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Irmen de Jong (irmen)
Assigned to: Nobody/Anonymous (nobody)
Summary: Fix for 926423: socket timeouts + Ctrl-C don't play nice

Initial Comment:
Please have a close look at the attached patch.
Essentially, it fixes internal_select to not return
zero on error condition, and also adds a test for errno
at all calls to internal_select.

A few remarks:
1) as indicated in the patch, I'm not sure if errno
should also be tested in the internal_connect function;
2) 'timeout' is no longer a boolean indicating a
timeout condition, it should probably be renamed to
'selectresult' or something similar;
3) I'm not too happy with the fact that the
if(timeout==-1 && erro) test must be duplicated in a
lot of functions;
4) does it do the right thing? The check for
timeout==-1 MUST be there otherwise a lot of errors
turn up in the regression tests. With this patch they
run fine, btw



----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1102879&group_id=5470