[Patches] [ python-Patches-1221598 ] ftplib storbinary/storlines callback function

[SourceForge.net]

Patches item #1221598, was opened at 2005-06-15 16:15
Message generated for change (Settings changed) made by phil_schwartz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1221598&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Modules
Group: Python 2.4
Status: Open
Resolution: None
Priority: 5
Submitted By: Phil Schwartz (phil_schwartz)
Assigned to: Nobody/Anonymous (nobody)
>Summary: ftplib storbinary/storlines callback function

Initial Comment:
The ftplib.FTP class currently allows the ability to
provide a callback function for the retrbinary &
retrlines methods to invoke.  However, the
corresponding storbinary and storlines methods do not.

My ReleaseForge application currently uses the ftplib
to send files (rather than retrieve) and it's helpful
to know the percentage of the file that has been sent.
 For my app I subclassed ftplib.FTP and reimplemented
storbinary to optionally accept a callback function as
a parameter.  

However, I think this would be a useful method to
include in the standard python distribution.  I've
attached a modified version of ftplib.py which adds
this functionality.  Unlike the retrX methods, the
storX methods only invoke the callback function if it's
not None so that it will not interfere with existing
code.  For completeness, the retrX methods invoke
print_line if a callback function is not provided and
doing so for the storX functions may be undesired.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1221598&group_id=5470