[Patches] [ python-Patches-1327377 ] VS NET 2003 Project Files contain per file compiler settings

[SourceForge.net]

Patches item #1327377, was opened at 2005-10-15 11:22
Message generated for change (Comment added) made by babydoe
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1327377&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Build
Group: Python 2.4
Status: Open
Resolution: None
Priority: 5
Submitted By: Doe, Baby (babydoe)
Assigned to: Nobody/Anonymous (nobody)
Summary: VS NET 2003 Project Files contain per file compiler settings

Initial Comment:
A review of the vcproj files shows that not only the
"global" compiler settings affect the compilation, but
also most (not all) of the files to be compiled have
their own overriding compiler settings.

For example mathmodule.c (in pythoncore.vcproj):
		<File
			RelativePath="..\Modules\mathmodule.c">
			<FileConfiguration
				Name="Release|Win32">
				<Tool
					Name="VCCLCompilerTool"
					Optimization="2"
					AdditionalIncludeDirectories=""
			
PreprocessorDefinitions="NDEBUG;WIN32;_WINDOWS;USE_DL_EXPORT;$(NoInherit)"/>
			</FileConfiguration>
			<FileConfiguration
				Name="Debug|Win32">
				<Tool
					Name="VCCLCompilerTool"
					Optimization="0"
					AdditionalIncludeDirectories=""
				
PreprocessorDefinitions="_DEBUG;USE_DL_EXPORT;WIN32;_WINDOWS;$(NoInherit)"/>
			</FileConfiguration>
			<FileConfiguration
				Name="ReleaseItanium|Win32">
				<Tool
					Name="VCCLCompilerTool"
					Optimization="2"
					AdditionalIncludeDirectories=""
				
PreprocessorDefinitions="NDEBUG;WIN32;_WINDOWS;USE_DL_EXPORT;$(NoInherit)"/>
			</FileConfiguration>
		</File>

This per file definition makes it very time consuming
to globally change compiler settings for an specific
build (for example adding/removing a preprocessor
definition, or changing the optimisation levels)

Are this per file definitions really necessary (imho
no, but i'm not one of the python developers), or are
they just an artifact of importing the VS6 projects
(this happened to me with all of my converted projects) ?

If the per file configuration is not really necessary
it can be safelly removed by deleting the
<FileConfiguration  ...	</FileConfiguration>
elements contained in the <File ... </File> tags


----------------------------------------------------------------------

>Comment By: Doe, Baby (babydoe)
Date: 2005-10-15 12:52

Message:
Logged In: YES 
user_id=458368

I have to make the changes anyway for my static build, so i
can provide a patch ...

Do you have any special instructions or should i just post a
zip file with the "patched" vcproj files ?
Should I use the files in the 2.4.2 Source distribution
(this is my current base), or do you want me to use the
anonymous CVS ?

----------------------------------------------------------------------

Comment By: Reinhold Birkenfeld (birkenfeld)
Date: 2005-10-15 12:24

Message:
Logged In: YES 
user_id=1188172

Are you willing to provide a patch? Else this must be moved
to the "bugs" tracker.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1327377&group_id=5470