[Patches] [ python-Patches-1464062 ] Simple test for os.startfile

SourceForge.net noreply at sourceforge.net
Tue Apr 4 20:43:37 CEST 2006


Patches item #1464062, was opened at 2006-04-04 10:53
Message generated for change (Comment added) made by theller
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1464062&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: Python 2.5
>Status: Closed
Resolution: Accepted
Priority: 5
Submitted By: Thomas Heller (theller)
Assigned to: Thomas Heller (theller)
Summary: Simple test for os.startfile

Initial Comment:
The attached file test_startfile.py is a very simple
test for os.startfile on Windows.  It needs an empty
file 'empty.vbs' as well.

----------------------------------------------------------------------

>Comment By: Thomas Heller (theller)
Date: 2006-04-04 20:43

Message:
Logged In: YES 
user_id=11105

Committed as rev. 43644 and rev. 43645.  Changed the unicode
conversion, and added some comments.

Thanks.

----------------------------------------------------------------------

Comment By: Neal Norwitz (nnorwitz)
Date: 2006-04-04 20:38

Message:
Logged In: YES 
user_id=33168

Thanks Thomas!  I'll check about the non-Windows platforms.

----------------------------------------------------------------------

Comment By: Thomas Heller (theller)
Date: 2006-04-04 20:19

Message:
Logged In: YES 
user_id=11105

Do I have to add something to Lib/test/regrtest.py, so that
the test is skipped on non-Windows platforms?

----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2006-04-04 20:13

Message:
Logged In: YES 
user_id=21627

The patch looks fine, except that the conversion of a path
name to Unicode should use the "mbcs" codec. Please apply
(before the trunk freeze, or after the unfreeze); please
also add empty.vbs to Tools/msi/msi.py

----------------------------------------------------------------------

Comment By: Thomas Heller (theller)
Date: 2006-04-04 11:26

Message:
Logged In: YES 
user_id=11105

Updated the test to work when run from different directory.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1464062&group_id=5470


More information about the Patches mailing list