[Patches] [ python-Patches-1463288 ] clean up new calendar locale usage

SourceForge.net noreply at sourceforge.net
Mon Apr 10 08:44:26 CEST 2006


Patches item #1463288, was opened at 2006-04-02 20:21
Message generated for change (Settings changed) made by nnorwitz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1463288&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
>Category: Library (Lib)
Group: Python 2.5
Status: Open
Resolution: None
Priority: 5
Submitted By: Neal Norwitz (nnorwitz)
Assigned to: Walter Dörwald (doerwalter)
Summary: clean up new calendar locale usage

Initial Comment:
Walter,

I don't know if this is really better or not.  I was
wondering if the new with statement would help cleanup
the locale handling (all the try-finallys).  It reduces
the total lines of code a little bit.  It seems a
little cleaner to me.  I didn't see any tests for the
new classes, so I only tested on the command line and
it seemed to work.  Regardless of whether you like this
patch or not, it would be good to add tests for the new
classes in calendar.

I'm probably about +0 on this patch.  It was more an
experiment to see if the code was clearer.  I think
it's marginally better at most.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1463288&group_id=5470


More information about the Patches mailing list