[Patches] [ python-Patches-1412448 ] Compile under mingw properly

[SourceForge.net]

Patches item #1412448, was opened at 2006-01-23 03:10
Message generated for change (Comment added) made by loewis
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1412448&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Build
Group: Python 2.4
Status: Open
Resolution: None
Priority: 5
Submitted By: Alexandre Girão Bezerra de Mene (alexgirao)
Assigned to: Martin v. Löwis (loewis)
Summary: Compile under mingw properly

Initial Comment:
Hi,

 I made only simple changes to let gcc happy with win
related code and to compile without warnings.

Alexadre Girao,
http://nextt.org


----------------------------------------------------------------------

>Comment By: Martin v. Löwis (loewis)
Date: 2006-04-10 15:01

Message:
Logged In: YES 
user_id=21627

Unfortunately, the patch is unacceptable in its current
form. Some of the changes seem essential to make Python work
with Mingw, others seem merely aesthetical (i.e. those that
make warnings go away).

Some of the changes that make warnings go away look wrong:
the code is right as it stands, and if you get a warning
with MingW, it's either that the compiler is wrong, or some
other part of the setup is broken.

Would you be willing to rework the patch to only include the
fragments that are absolutely necessary to make it compile
and work correctly? Also, it would be much more useful if
you could forward-port the patch to the 2.5 subversion trunk.

Among the things I consider faulty are:
- inclusion of wincrypt.h
- addition of a parenthesis around the cFileName[1/2] block
- explicit conversion of arguments to const char**


----------------------------------------------------------------------

Comment By: Alexandre Girão Bezerra de Mene (alexgirao)
Date: 2006-01-25 00:34

Message:
Logged In: YES 
user_id=700047

Most of the changes were related to correct usage of braces 
and incompatibilities with mingw (note that i compiled with 
msvc too). The parenthesis changes apply to msvc too.

I thank you so much for paying attention on this.


----------------------------------------------------------------------

Comment By: Jim Jewett (jimjjewett)
Date: 2006-01-25 00:19

Message:
Logged In: YES 
user_id=764593

Are you sure these were just compiler-related?

Changing things like frequency from {0,0} to {{0,}} or 
adding parentheses strike me as at least possible bugfixes 
that should not be in #ifdefs

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1412448&group_id=5470