[Patches] [ python-Patches-1540874 ] broken shortcut keys

SourceForge.net noreply at sourceforge.net
Fri Dec 1 22:07:43 CET 2006


Patches item #1540874, was opened at 2006-08-15 15:29
Message generated for change (Comment added) made by kbk
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1540874&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: IDLE
Group: Python 2.5
Status: Closed
Resolution: Fixed
Priority: 7
Private: No
Submitted By: Jim Jewett (jimjjewett)
Assigned to: Kurt B. Kaiser (kbk)
Summary: broken shortcut keys

Initial Comment:
Idle menu entries can include a "_" indicating to use 
that character for a keyboard shortcut.  

Because Typing the key actually runs the shortcut 
(instead of just moving along the menu), there is no 
way to use the same shortcut on more than one entry -- 
listing it just misleads people into accidentally 
requesting the wrong command.

Unfortunately, the default configuration does this for 
the File menu.  It claims that Alt-f-p will save a 
copy as and print, but it actually just opens a path 
browser.

This change
(1)  Uses the y key for save Cop_y
(2)  Stops pretending to have a key for print.

I'll trust someone else's judgement on whether this is 
a bugfix (the advertised shortcuts don't work) or a 
feature (particularly the new binding for copy).



----------------------------------------------------------------------

>Comment By: Kurt B. Kaiser (kbk)
Date: 2006-12-01 16:07

Message:
Logged In: YES 
user_id=149084
Originator: NO

If you were to work up a patch to display a Tk dialog, that would help
until we can address printing properly.  The current implementation is
a quick cut by Guido.  I suppose it goes to the default printer, but
I've have to go read the code.

----------------------------------------------------------------------

Comment By: Tal Einat (taleinat)
Date: 2006-11-21 09:49

Message:
Logged In: YES 
user_id=1330769
Originator: NO

Perhaps Ctrl+P is the standard keybinding for printing on Windows, but the
windows standard is that the print command opens a print dialog. Therefore,
is you invoked the command by mistake, you just hit "cancel" in the dialog.
However this isn't the case in IDLE - IDLE just prints all of the text in
the window.

I've personally been bitten by this and several others, since we didn't
know that Ctrl+P just sent the entire text to be printed. IDLE doesn't
even notify you that you've sent the data for printing, so sometimes this
is realized only after the entire thing has been printed.

So if it's sticking to the standards we want, we should have IDLE pop up a
"print..." dialog on Windows. (shouldn't be too hard with win32, is it
possible without it?)

----------------------------------------------------------------------

Comment By: Kurt B. Kaiser (kbk)
Date: 2006-11-20 21:56

Message:
Logged In: YES 
user_id=149084
Originator: NO

Ctrl-P is the standard binding for Print on Windows.
If you don't like it, assign it to some other key
using your Options dialog.  I don't want a patch,
thanks anyway!

----------------------------------------------------------------------

Comment By: Kurt B. Kaiser (kbk)
Date: 2006-11-20 21:55

Message:
Logged In: YES 
user_id=149084
Originator: NO

Ctrl-P is the standard binding for Print on Windows.
If you don't like it, assign it to some other key
using your Options dialog.  I don't want a patch,
thanks anyway!

----------------------------------------------------------------------

Comment By: Tal Einat (taleinat)
Date: 2006-11-20 14:33

Message:
Logged In: YES 
user_id=1330769
Originator: NO

I actually prefer to not have a key for the "Print" item, since
accidentally choosing it will print all of the code in the current
window.

On the same note, I think the default keybinding for the "Print" command
shouldn't be Ctrl+P as it is now, for the same reason stated above. I
prefer to have no key binding for it, since it isn't such a commonplace
command, and invoking it accidentally is a major annoyance. 

However, currently IDLE assumes that every key in the keybindigs list must
have a keybinding. If we don't want to change this, or if we insist on
having a default keybinding for "Print", let's choose a combination that
is less likely to be pressed accidentaly. (perhaps Ctrl+Alt+P)

I could easily write a patch for this, just want to ask what you think
should be done.

----------------------------------------------------------------------

Comment By: Kurt B. Kaiser (kbk)
Date: 2006-08-16 17:48

Message:
Logged In: YES 
user_id=149084

I chose 'T' for Print.  Also modified the Shell menu
hotkey, it's now 'L'.

Rev 51329

----------------------------------------------------------------------

Comment By: Jim Jewett (jimjjewett)
Date: 2006-08-15 15:57

Message:
Logged In: YES 
user_id=764593

Changing priority to 7 because I consider it a bug, but am 
reluctant to push GUI changes after release.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1540874&group_id=5470


More information about the Patches mailing list