[Patches] [ python-Patches-1544279 ] Socket module is not thread-safe

[SourceForge.net]

Patches item #1544279, was opened at 2006-08-22 01:24
Message generated for change (Comment added) made by loewis
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1544279&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Core (C code)
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 7
Private: No
Submitted By: Maxim Sobolev (sobomax)
Assigned to: Martin v. Löwis (loewis)
Summary: Socket module is not thread-safe

Initial Comment:
The socket module make a great effort to be thread-
safe, but misses one 
big point - it uses single per-instance buffer to hold 
resolved 
sockaddr_xxx structures. Therefore, on SMP system it 
is possible that 
several threads calling functions that perform address 
resolution in 
parallel will stomp on each other resulting in 
incorrect or invalid address 
to be used in each case.

For example, two threads calling sendto() in parallel 
can result in packets 
to be sent to incorrect addresses - packets from 
thread one from time to 
time will be sent to address requested by thread two 
and vice versa.

Another, smaller issue is that the call to getnameinfo
() is not protected 
with netdb mutex on systems that don't have thread-
safe resolver.

P.S. This is very serious problem for us. For some 
reason my previous patch submission has been 
downgraded to bug report and forgotten completely, so 
that I am re-submitting.

----------------------------------------------------------------------

>Comment By: Martin v. Löwis (loewis)
Date: 2006-12-03 12:24

Message:
Logged In: YES 
user_id=21627
Originator: NO

Thanks for the patch. Committed as r52906 and r52907.

----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2006-08-22 01:42

Message:
Logged In: YES 
user_id=21627

Sorry about forgetting your patch. Will look at it again for 2.5.1.

P.S. The previous issue was #1467080. It wasn't "downgraded to bug
report"; 
instead, you submitted it as a bug report to start with.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1544279&group_id=5470