[Patches] [ python-Patches-1520879 ] make install change: Allow $DESTDIR to be relative

SourceForge.net noreply at sourceforge.net
Wed Dec 6 00:45:27 CET 2006


Patches item #1520879, was opened at 2006-07-12 00:56
Message generated for change (Comment added) made by hanwen
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1520879&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Build
Group: Python 2.5
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Douglas Greiman (dgreiman)
Assigned to: Nobody/Anonymous (nobody)
Summary: make install change: Allow $DESTDIR to be relative

Initial Comment:
This patch allows the $DESTDIR variable used in 'make
install' to be a relative path.  It also avoids
constructing filenames starting with double slashes
('//') when DESTDIR is an absolute path.

Tested on RedHat 9.0 Linux on x86.


----------------------------------------------------------------------

Comment By: Han-Wen Nienhuys (hanwen)
Date: 2006-12-05 23:45

Message:
Logged In: YES 
user_id=161998
Originator: NO

Agreed. I have never seen $DESTDIR prefixed with / in makefiles, so this
patch should go in.

I don't see the point of making --prefix relative. 
you can do 

 --prefix=`cd ../relative ; pwd` 

if you need relative.

Putting relative paths in makefiles is asking for trouble, as the Makefile
will call other makefiles in subdirectories, which would need to pass extra
../ overrides of prefix.
 

----------------------------------------------------------------------

Comment By: Douglas Greiman (dgreiman)
Date: 2006-08-01 00:03

Message:
Logged In: YES 
user_id=1553997

That seems reasonable, however I believe it should be a
separate change since codewise the two changes are unrelated.

----------------------------------------------------------------------

Comment By: Chad Whitacre (whit537)
Date: 2006-07-31 22:13

Message:
Logged In: YES 
user_id=340931

I'd also like to see the argument to 'configure --prefix='
also be relative. Could this patch be expanded in that
direction?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1520879&group_id=5470


More information about the Patches mailing list