[Patches] [ python-Patches-1608267 ] Makefile fix

SourceForge.net noreply at sourceforge.net
Wed Dec 6 15:25:37 CET 2006


Patches item #1608267, was opened at 2006-12-04 05:29
Message generated for change (Comment added) made by hanwen
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1608267&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Build
Group: Python 2.6
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Hasan Diwan (hdiwan650)
Assigned to: Nobody/Anonymous (nobody)
Summary: Makefile fix

Initial Comment:
Create the DESTDIR as part of the make install process.

----------------------------------------------------------------------

Comment By: Han-Wen Nienhuys (hanwen)
Date: 2006-12-06 14:25

Message:
Logged In: YES 
user_id=161998
Originator: NO

can you be more specific about the problem?

the install -d should come just before the 
command attempting to copy something into that dir.


----------------------------------------------------------------------

Comment By: Hasan Diwan (hdiwan650)
Date: 2006-12-06 14:24

Message:
Logged In: YES 
user_id=1185570
Originator: YES

Ok, I'll change the patch to use install as opposed to mkdir in a few
days.

I was hitting a problem in installing python, which I have since solved by
using this patch. So, I decided to submit it. 

----------------------------------------------------------------------

Comment By: Han-Wen Nienhuys (hanwen)
Date: 2006-12-05 22:55

Message:
Logged In: YES 
user_id=161998
Originator: NO

Hello,

* directory creation is usually done with install -d ; see numerous
examples in the rest of the 
Makefile.

* What does this fix? AFAIK, DESTDIR is already made, as part of 
directories like

               if test ! -d $(DESTDIR)$$i; then \
                        echo "Creating directory $$i"; \
                        $(INSTALL) -d -m $(DIRMODE) $(DESTDIR)$$i; \
                else    true; \
 



----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1608267&group_id=5470


More information about the Patches mailing list